[e10s] Cannot touch scroll multiple tabs

VERIFIED FIXED in Firefox 52

Status

()

Toolkit
XUL Widgets
VERIFIED FIXED
7 months ago
3 months ago

People

(Reporter: petruta, Assigned: kats)

Tracking

(Blocks: 1 bug)

51 Branch
mozilla52
All
Windows 10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10s+, firefox50 unaffected, firefox51 unaffected, firefox52 verified)

Details

(Whiteboard: [nightly only])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

7 months ago
[Note]:
- Create 'browser.tabs.remote.force-enable' preference and set it to true. Restart the browser.

[Affected versions]:
- Nightly 51.0a1 2016-09-14

[Affected platforms]:
- Microsoft Surface Pro 2 with Win 10 64-bit

[Steps to reproduce]:
1. Open multiple tabs so that the tab bar can be scrolled 
2. Touch scroll the tabs
3. Tap "X" to close a tab

[Expected result]:
2. The tabs can be scrolled
3. The tabs are rearranged after closing one of them

[Actual result]:
2. The tabs cannot be scrolled
3. An empty space remains on the right side of Tab Bar.
(Assignee)

Updated

7 months ago
Blocks: 1244402

Updated

7 months ago
tracking-e10s: ? → +
The tab bar is a <scrollbox> which process wheel events to do scrolling. Fixing this may require adding touch event listeners to scrollbox.xml.

Comment 2

7 months ago
(In reply to Markus Stange [:mstange] from comment #1)
> The tab bar is a <scrollbox> which process wheel events to do scrolling.
> Fixing this may require adding touch event listeners to scrollbox.xml.

Why would this only manifest with e10s though? Sounds like a core :: event handling bug to me.
Flags: needinfo?(mstange)
We only fire touch events when e10s is enabled. Without e10s we don't have the machinery to properly support touch events and they get converted to mouse events instead.
Flags: needinfo?(mstange)

Updated

7 months ago
Component: Tabbed Browser → XUL Widgets
Product: Firefox → Toolkit
How does touch scrolling work with those simulated mouse events? Do we synthesize wheel events?
With e10s disabled you mean? Yeah, there's some goop in nsWinGesture.cpp that gets gesture events from Windows (as opposed to WM_TOUCH messages) and dispatches it as wheel events.
Ah, interesting.
Working on this. I have a patch that makes the scrolling work already, but I want to fix the "empty space left on the side of the tab bar after closing a bunch of tabs" as well. That code appears to be somewhere other than scrollbox.xml
Assignee: nobody → bugmail
(Assignee)

Updated

7 months ago
status-firefox51: affected → unaffected
status-firefox52: --- → affected
Whiteboard: [nightly only]
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
The try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=3067b29ef288&group_state=expanded includes the first patch on this bug.

Comment 11

7 months ago
mozreview-review
Comment on attachment 8795399 [details]
Bug 1302737 - When closing tabs with non-mouse devices (e.g. touch, pen), don't enter locked-tab-size mode.

https://reviewboard.mozilla.org/r/81456/#review80028
Attachment #8795399 - Flags: review?(gijskruitbosch+bugs) → review+
Attachment #8795398 - Flags: review?(jaws) → review?(dao+bmo)
Comment on attachment 8795398 [details]
Bug 1302737 - Add rudimentary touch-scrolling support to the XUL scrollbox widget.

see bug 1302736 comment 11
Attachment #8795398 - Flags: review?(dao+bmo) → review+

Comment 13

7 months ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d39febef604
Add rudimentary touch-scrolling support to the XUL scrollbox widget. r=dao
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2bac20c2f76
When closing tabs with non-mouse devices (e.g. touch, pen), don't enter locked-tab-size mode. r=Gijs

Comment 14

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4d39febef604
https://hg.mozilla.org/mozilla-central/rev/f2bac20c2f76
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
(Reporter)

Comment 15

6 months ago
Verified as fixed with 50.0a1 Nightly 2016-10-18.
Status: RESOLVED → VERIFIED
status-firefox52: fixed → verified
(Assignee)

Updated

3 months ago
Blocks: 1334161
You need to log in before you can comment on or make changes to this bug.