Ensure that tasks in a taskgraph do not have duplicate gecko.v2 routes

RESOLVED FIXED in mozilla53

Status

Taskcluster
Task Configuration
RESOLVED FIXED
11 months ago
8 months ago

People

(Reporter: dustin, Assigned: HAMMAD AKHTAR, Mentored)

Tracking

({good-first-bug})

unspecified
mozilla53
good-first-bug

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

11 months ago
We use routes beginning with 'index.gecko.v2' to find particular tasks based on revision or time.  We want to consistently find the *right* task, and things get very confusing if there are two tasks in the same task graph that have the same index route -- you never know which one you'll find!

Something in the decision task should check that all gecko.v2 index routes are distinct, and fail if not.

Bonus points for implementing a fairly generic way to plug in graph verification functions.

Comment 1

11 months ago
This is definitely a good check to have, and we've run into issues without this check before (bug 1214758). Bug 1214760 added the check as part of the previous task generation code, though I don't think code from that is a good reference anymore.
See Also: → bug 1214760
(Reporter)

Updated

9 months ago
Assignee: nobody → dustin
(Reporter)

Updated

8 months ago
Assignee: dustin → hammad13060
Comment hidden (mozreview-request)
(Assignee)

Comment 3

8 months ago
Comment on attachment 8820698 [details]
Bug 1302804 - Ensure that tasks in a taskgraph do not have duplicate gecko.v2 routes;

Hey Dustin, I ran the tests and one job got busted, but I think that doesn't seem to be any issue. I am ready for review :)
(Reporter)

Comment 4

8 months ago
mozreview-review
Comment on attachment 8820698 [details]
Bug 1302804 - Ensure that tasks in a taskgraph do not have duplicate gecko.v2 routes;

https://reviewboard.mozilla.org/r/100160/#review100650

Nice work!  I'm loving this verification :)
Attachment #8820698 - Flags: review?(dustin) → review+

Comment 5

8 months ago
Pushed by dmitchell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/98aa6bc9a2d3
Ensure that tasks in a taskgraph do not have duplicate gecko.v2 routes; r=dustin

Comment 6

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/98aa6bc9a2d3
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
(In reply to Pulsebot from comment #5)
> Pushed by dmitchell@mozilla.com:
> https://hg.mozilla.org/integration/autoland/rev/98aa6bc9a2d3
> Ensure that tasks in a taskgraph do not have duplicate gecko.v2 routes;
> r=dustin

Note to self, file a new bug and get myself to write if it blocks my next `date` merge, (which I haven't done yet since this landed) or have Hammad write it for me :-)

(re: Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1325398#c3 )
Flags: needinfo?(bugspam.Callek)
(In reply to Justin Wood (:Callek) from comment #7)
> (In reply to Pulsebot from comment #5)
> > Pushed by dmitchell@mozilla.com:
> > https://hg.mozilla.org/integration/autoland/rev/98aa6bc9a2d3
> > Ensure that tasks in a taskgraph do not have duplicate gecko.v2 routes;
> > r=dustin
> 
> Note to self, file a new bug and get myself to write if it blocks my next
> `date` merge, (which I haven't done yet since this landed) or have Hammad
> write it for me :-)
> 
> (re: Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1325398#c3 )

Filed Bug 1326462
Flags: needinfo?(bugspam.Callek)
You need to log in before you can comment on or make changes to this bug.