1302804 - Ensure that tasks in a taskgraph do not have duplicate gecko.v2 routes

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

We use routes beginning with 'index.gecko.v2' to find particular tasks based on revision or time.  We want to consistently find the *right* task, and things get very confusing if there are two tasks in the same task graph that have the same index route -- you never know which one you'll find!

Something in the decision task should check that all gecko.v2 index routes are distinct, and fail if not.

Bonus points for implementing a fairly generic way to plug in graph verification functions.

Comment 1

[Michael Shal [:mshal]]

This is definitely a good check to have, and we've run into issues without this check before (bug 1214758). Bug 1214760 added the check as part of the previous task generation code, though I don't think code from that is a good reference anymore.

Comment 2

[HAMMAD AKHTAR]

Attachment: Bug 1302804 - Ensure that tasks in a taskgraph do not have duplicate gecko.v2 routes;

Review commit: https://reviewboard.mozilla.org/r/100160/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100160/

Comment 3

[HAMMAD AKHTAR]

Comment on attachment 8820698 [details]
Bug 1302804 - Ensure that tasks in a taskgraph do not have duplicate gecko.v2 routes;

Hey Dustin, I ran the tests and one job got busted, but I think that doesn't seem to be any issue. I am ready for review :)

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8820698 [details]
Bug 1302804 - Ensure that tasks in a taskgraph do not have duplicate gecko.v2 routes;

https://reviewboard.mozilla.org/r/100160/#review100650

Nice work!  I'm loving this verification :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98aa6bc9a2d3
Ensure that tasks in a taskgraph do not have duplicate gecko.v2 routes; r=dustin

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/98aa6bc9a2d3

Comment 7

[Justin Wood (:Callek)]

(In reply to Pulsebot from comment #5)
> Pushed by [e-mail]:
> https://hg.mozilla.org/integration/autoland/rev/98aa6bc9a2d3
> Ensure that tasks in a taskgraph do not have duplicate gecko.v2 routes;
> r=dustin

Note to self, file a new bug and get myself to write if it blocks my next `date` merge, (which I haven't done yet since this landed) or have Hammad write it for me :-)

(re: Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1325398#c3 )

Comment 8

[Justin Wood (:Callek)]

(In reply to Justin Wood (:Callek) from comment #7)
> (In reply to Pulsebot from comment #5)
> > Pushed by [e-mail]:
> > https://hg.mozilla.org/integration/autoland/rev/98aa6bc9a2d3
> > Ensure that tasks in a taskgraph do not have duplicate gecko.v2 routes;
> > r=dustin
> 
> Note to self, file a new bug and get myself to write if it blocks my next
> `date` merge, (which I haven't done yet since this landed) or have Hammad
> write it for me :-)
> 
> (re: Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1325398#c3 )

Filed Bug 1326462