Closed Bug 1302843 Opened 3 years ago Closed 3 years ago

Missing some action guards in Predictor::UpdateCacheability

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: u408661, Assigned: u408661)

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

While looking for the root cause of bug 1267820, I noticed that Predictor::UpdateCacheability was possibly running when it shouldn't (or at least when it didn't make much sense for it to) - when the predictor was uninitialized, for example. That should be fixed.
Comment on attachment 8791372 [details]
Bug 1302843 - Don't UpdateCacheabilityInternal if not enabled/initialized.

https://reviewboard.mozilla.org/r/78792/#review77788
Attachment #8791372 - Flags: review?(honzab.moz) → review+
Pushed by hurley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c2cd6896be7
Don't UpdateCacheabilityInternal if not enabled/initialized. r=mayhemer
https://hg.mozilla.org/mozilla-central/rev/7c2cd6896be7
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.