Closed Bug 1302865 Opened 4 years ago Closed 4 years ago

Bug Modal doesn't seem to work for Mandatory/Mandatory groups

Categories

(bugzilla.mozilla.org :: User Interface, defect, P1)

Production
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: dylan, Assigned: dkl)

References

Details

Attachments

(3 files, 1 obsolete file)

STR: Attempt to needinfo someone on a bug in a product that has a default group that is Mandatory/Mandatory.

The error group_invalid_removal will be triggered.
Message: "You tried to remove bug 1301084 from the 'legal' group, but either this group does not exist, or you are not allowed to remove bugs from this group in the 'Legal' product. "
Blocks: 1150541
these are the params sent by the traditional enter bug form
Attached file enter-bug-modal.params
And these are the params for bug modal
We shouldn't be setting defined_* for groups that are mandatory.

Easy fix
Assignee: nobody → dylan
Depends on: 1303342
Attached patch 1302865_3.patch (obsolete) — Splinter Review
Attachment #8792092 - Flags: review?(dkl)
Comment on attachment 8792092 [details] [diff] [review]
1302865_3.patch

Review of attachment 8792092 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Dylan Hardison [:dylan] from comment #4)
> Created attachment 8792092 [details] [diff] [review]
> 1302865_3.patch

I actually like seeing the mandatory group still listed even in the edit view. The disabled checkbox does a good job of describing that the bug cannot be removed from the group. We could also alternatively remove the checkbox and add (mandatory) to the right of the group description. Either way, this patch also fixes the issue in this bug:

diff --git a/extensions/BugModal/template/en/default/bug_modal/groups.html.tmpl b/extensions/BugModal/template/en/default/bug_modal/groups.html.tmpl
index 5821372..8315f23 100644
--- a/extensions/BugModal/template/en/default/bug_modal/groups.html.tmpl
+++ b/extensions/BugModal/template/en/default/bug_modal/groups.html.tmpl
@@ -55,7 +55,7 @@
       <b>Only users in all of the selected groups can view this [% terms.bug %]:</b>
     [% END %]

-    [% IF group.ingroup %]
+    [% IF group.ingroup && !group.mandatory %]
       <input type="hidden" name="defined_groups" value="[% group.name FILTER html %]">
     [% END %]
Attachment #8792092 - Flags: review?(dkl) → review-
cool, I'll swap assignee with you and review that patch :-)
Assignee: dylan → dkl
Attached patch 1302865_1.patchSplinter Review
Attachment #8792092 - Attachment is obsolete: true
Attachment #8817510 - Flags: review?(dylan)
Comment on attachment 8817510 [details] [diff] [review]
1302865_1.patch

Review of attachment 8817510 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan
Attachment #8817510 - Flags: review?(dylan)
Comment on attachment 8817510 [details] [diff] [review]
1302865_1.patch

sorry, flakey wifi
Attachment #8817510 - Flags: review+
To https://github.com/mozilla-bteam/bmo.git
   89c6b2b..8f4c497  master -> master
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Component: User Interface: Modal → User Interface
You need to log in before you can comment on or make changes to this bug.