Closed Bug 1302879 Opened 4 years ago Closed 4 years ago
.html/test/browser/browser _device _change .js | Test timed out -
58 bytes, text/x-review-board-request
Filed by: wkocher [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=35849739&repo=mozilla-inbound https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win32-debug/1473854227/mozilla-inbound_win7_vm-debug_test-mochitest-e10s-devtools-chrome-5-bm129-tests1-windows-build365.txt.gz
Very frequent and clearly fallout from bug 1254388.
Priority: -- → P3
Whiteboard: [multiviewport] [triage] → [multiviewport][reserve-rdm]
:zer0 is investigating this.
Assignee: nobody → zer0
Status: NEW → ASSIGNED
Iteration: --- → 52.1 - Oct 3
Priority: P3 → P1
I faced this issue working on bug 1276971. Basically with bug 1254388, now we automatically enable the touch event if the device selected in the dropdown is a touch device. Unfortunately, that also means that we reload the content page. Sometimes, we have a racing condition where the content is adding the listener to emit the `content-resize` too late – when the resize already happened – therefore the test hangs forever, waiting for something it would never happens. This patch fixes the `waitForViewportResizeTo` function used in the tests, taking in account the racing condition described above – and, to play safe, also the scenario where the size is already the one expected.
At a first look, the oranges don't seem related to this patch.
Here the tree build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9397f0e224e
Comment on attachment 8796235 [details] Bug 1302879 - Intermittent browser_device_change.js | Test timed out; https://reviewboard.mozilla.org/r/82140/#review80866 Seems like a reasonable fix to me, let's go with it. Thanks for working on this!
Attachment #8796235 - Flags: review?(jryans) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/fx-team/rev/af6e01b8574b Intermittent browser_device_change.js | Test timed out; r=jryans
You need to log in before you can comment on or make changes to this bug.