Closed Bug 1302879 Opened 3 years ago Closed 3 years ago

Intermittent devtools/client/responsive.html/test/browser/browser_device_change.js | Test timed out -

Categories

(DevTools :: Responsive Design Mode, defect, P1)

defect

Tracking

(firefox50 unaffected, firefox51 fixed, firefox52 fixed)

RESOLVED FIXED
Firefox 52
Iteration:
52.1 - Oct 3
Tracking Status
firefox50 --- unaffected
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: zer0)

References

Details

(Keywords: intermittent-failure, Whiteboard: [multiviewport][reserve-rdm])

Attachments

(1 file)

Very frequent and clearly fallout from bug 1254388.
Blocks: 1254388
Flags: needinfo?(zer0)
Whiteboard: [multiviewport] [triage]
Priority: -- → P3
Whiteboard: [multiviewport] [triage] → [multiviewport][reserve-rdm]
:zer0 is investigating this.
Assignee: nobody → zer0
Status: NEW → ASSIGNED
Iteration: --- → 52.1 - Oct 3
Flags: qe-verify-
Priority: P3 → P1
I faced this issue working on bug 1276971.
Basically with bug 1254388, now we automatically enable the touch event if the device selected in the dropdown is a touch device. Unfortunately, that also means that we reload the content page. Sometimes, we have a racing condition where the content is adding the listener to emit the `content-resize` too late – when the resize already happened – therefore the test hangs forever, waiting for something it would never happens.
This patch fixes the `waitForViewportResizeTo` function used in the tests, taking in account the racing condition described above – and, to play safe, also the scenario where the size is already the one expected.
Flags: needinfo?(zer0)
At a first look, the oranges don't seem related to this patch.
Comment on attachment 8796235 [details]
Bug 1302879 - Intermittent browser_device_change.js | Test timed out;

https://reviewboard.mozilla.org/r/82140/#review80866

Seems like a reasonable fix to me, let's go with it.  Thanks for working on this!
Attachment #8796235 - Flags: review?(jryans) → review+
Pushed by mferretti@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/af6e01b8574b
Intermittent browser_device_change.js | Test timed out; r=jryans
https://hg.mozilla.org/mozilla-central/rev/af6e01b8574b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Depends on: 1306816
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.