1302890 - missing chrome://global/skin/icons/warning-32.png referenced from chrome://devtools/skin/tooltips.css

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[Florian Quèze [:florian]]

Found as part of bug 1302570. The warning-32.png file only exists on Mac.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

:jdescottes, maybe you can help?  It looks like you've worked on tooltips.css lately.

Comment 2

[Florian Quèze [:florian]]

When fixing this, please remove the exception at https://hg.mozilla.org/mozilla-central/rev/4832e0d25e64#l2.37 or the test would fail.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: warning-icon-in-tooltip.png

This warning icon is used for only one tooltip in devtools, displayed when several debuggers are paused at the same time.

This a feature used by the old debugger, so likely to go away when switching to the new debugger frontend. And it has only ever worked on OSX. I propose to switch to a standard tooltip, with no icon and remove all the code related to this icon from devtools.

If we ever need to do a proper "warning" tooltip, we can create a proper one, using a devtools icon etc...

James: does that sound ok to you?

Comment 4

[James Long (:jlongster)]

Yes, that sounds great! Sorry for taking a while to respond. Thanks!

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1302890 - remove alert tooltip feature relying on unavailable image;

Review commit: https://reviewboard.mozilla.org/r/83228/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83228/

Comment 6

[Julian Descottes [:jdescottes]]

Gabriel, this is about removing a feature of the old xul tooltip that used to only work on OSX: the alert type text tooltip. It was relying on an image unavailable on other platforms. Only call site is the old debugger. 

We can reimplement the feature for the HTML tooltip if the requirement comes back later.

Comment 7

[Julian Descottes [:jdescottes]]

Comment on attachment 8797538 [details]
Bug 1302890 - remove alert tooltip feature relying on unavailable image;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/83228/diff/1-2/

Comment 8

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8797538 [details]
Bug 1302890 - remove alert tooltip feature relying on unavailable image;

https://reviewboard.mozilla.org/r/83228/#review81768

Comment 9

[Julian Descottes [:jdescottes]]

Thanks for the review Gabriel, try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=118ba52b28f11591b0ffdf4bb4ec17493f3d3364

Comment 10

[Julian Descottes [:jdescottes]]

Try is green except for unrelated intermittents (linux32 debug only timeouts). Landing.

Comment 11

[Julian Descottes [:jdescottes]]

Comment on attachment 8797538 [details]
Bug 1302890 - remove alert tooltip feature relying on unavailable image;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/83228/diff/2-3/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/c4a811b0531e
remove alert tooltip feature relying on unavailable image;r=gl

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c4a811b0531e