Closed Bug 1302909 Opened 3 years ago Closed 3 years ago

STDC_HEADERS (still) not set for debug linux static analysis builds

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(1 file)

glandium explains the problem in https://bugzilla.mozilla.org/show_bug.cgi?id=1299919#c2

What I neglected to notice when investigating this is that AC_TRY_CPP is the one checking stderr, and AC_HEADER_STDC uses AC_TRY_CPP. So although bug 1299919 fixed what we wanted it to, STDC_HEADERS is still not set for these builds.

I'm not sure what it would take to upgrade zlib on the testers. Given the circumstances it might be easier to just port these builds to TC.
Can't we just define STDC_HEADERS everywhere and skip that test?
(In reply to Mike Hommey [:glandium] from comment #1)
> Can't we just define STDC_HEADERS everywhere and skip that test?

That sounds reasonable.
Assignee: nobody → cmanchester
Comment on attachment 8791780 [details]
Bug 1302909 - Set STDC_HEADERS everywhere instead of relying on AC_HEADER_STDC.

https://reviewboard.mozilla.org/r/79068/#review78354

::: build/moz.configure/headers.configure:12
(Diff revision 1)
>  # Check for headers defining standard int types.
>  check_header('stdint.h')
>  have_inttypes = check_header('inttypes.h')
>  
> +# Assume we have ansi C header files available.
> +set_define('STDC_HEADERS', True)

(Note: I'm not even sure we do need to define it at all, considering the matches for STDC_HEADERS in the tree, but let's not scope bloat)
Comment on attachment 8791780 [details]
Bug 1302909 - Set STDC_HEADERS everywhere instead of relying on AC_HEADER_STDC.

https://reviewboard.mozilla.org/r/79068/#review78356
Attachment #8791780 - Flags: review?(mh+mozilla) → review+
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4a5fdfecb10
Set STDC_HEADERS everywhere instead of relying on AC_HEADER_STDC. r=glandium
https://hg.mozilla.org/mozilla-central/rev/f4a5fdfecb10
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.