Closed
Bug 1302917
Opened 7 years ago
Closed 7 years ago
Intermittent toolkit/components/url-classifier/tests/unit/test_streamupdater.js | xpcshell return code: 0
Categories
(Toolkit :: Safe Browsing, defect, P2)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla53
People
(Reporter: intermittent-bug-filer, Assigned: tnguyen)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
Filed by: philringnalda [at] gmail.com https://treeherder.mozilla.org/logviewer.html#?job_id=35883868&repo=mozilla-inbound https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win32-pgo/1473881431/mozilla-inbound_xp_ix_test_pgo-xpcshell-bm126-tests1-windows-build5.txt.gz
Updated•7 years ago
|
Priority: -- → P2
Comment 1•7 years ago
|
||
You're going to see a *lot* of these, because chasing down bustage with freshly reimaged WinXP slaves I had to trigger hundreds of WinXP xpcshell runs. I just hope it's a real intermittent we just hadn't happened to file yet, and not more reimage bustage.
Comment 2•7 years ago
|
||
(In reply to Phil Ringnalda (:philor) from comment #1) > I just hope it's a real intermittent we just hadn't happened to file > yet, and not more reimage bustage. What's the best way to tell? Wait for a week or two and check the OrangeFactor link?
Comment 3•7 years ago
|
||
Or a day or two and sort by the "Test Machine" column and see if it's multiple failures on just a few machines. Or look at the test failure with more understanding than I would have, and say "hey, that would only happen if some registry value that's supposed to be set was missing/some directory couldn't be written to/some other machine setup thing I can't think of was true."
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Priority: P2 → P5
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → tnguyen
Assignee | ||
Comment 8•7 years ago
|
||
This seems block bug 1315386, I would like to take it
Priority: P5 → P2
Comment hidden (mozreview-request) |
Assignee | ||
Comment 10•7 years ago
|
||
Running try 1x time to see if the intermittent occurs https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb0463e6474e07012a827819fd9473d171b67aa1
Assignee | ||
Comment 11•7 years ago
|
||
Just remove the callback which calls to next_test without waiting for running result
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8813091 [details] Bug 1302917 - Call callback correctly to Fix intermittent test_streamupdater.js https://reviewboard.mozilla.org/r/94610/#review95124
Attachment #8813091 -
Flags: review?(francois) → review+
Updated•7 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 13•7 years ago
|
||
Pushed by ihsiao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/22346c89219f Call callback correctly to Fix intermittent test_streamupdater.js r=francois
Keywords: checkin-needed
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/22346c89219f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment 15•7 years ago
|
||
Thomas, thanks for fixing this. Good job!
Updated•7 years ago
|
Comment 16•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/7b1a218bce5c
Flags: in-testsuite+
Comment 17•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/8c15d7857dce
You need to log in
before you can comment on or make changes to this bug.
Description
•