1302917 - Intermittent toolkit/components/url-classifier/tests/unit/test_streamupdater.js | xpcshell return code: 0

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=35883868&repo=mozilla-inbound

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win32-pgo/1473881431/mozilla-inbound_xp_ix_test_pgo-xpcshell-bm126-tests1-windows-build5.txt.gz

Comment 1

[Phil Ringnalda (:philor)]

You're going to see a *lot* of these, because chasing down bustage with freshly reimaged WinXP slaves I had to trigger hundreds of WinXP xpcshell runs. I just hope it's a real intermittent we just hadn't happened to file yet, and not more reimage bustage.

Comment 2

[François Marier [:francois]]

(In reply to Phil Ringnalda (:philor) from comment #1)
> I just hope it's a real intermittent we just hadn't happened to file
> yet, and not more reimage bustage.

What's the best way to tell? Wait for a week or two and check the OrangeFactor link?

Comment 3

[Phil Ringnalda (:philor)]

Or a day or two and sort by the "Test Machine" column and see if it's multiple failures on just a few machines. Or look at the test failure with more understanding than I would have, and say "hey, that would only happen if some registry value that's supposed to be set was missing/some directory couldn't be written to/some other machine setup thing I can't think of was true."

Comment 4

[Intermittent Failures Robot]

36 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 20
* autoland: 16

Platform breakdown:
* windowsxp: 36

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1302917&startday=2016-09-15&endday=2016-09-15&tree=all

Comment 5

[Intermittent Failures Robot]

42 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 20
* autoland: 20
* fx-team: 2

Platform breakdown:
* windowsxp: 42

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1302917&startday=2016-09-12&endday=2016-09-18&tree=all

Comment 6

[Intermittent Failures Robot]

5 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 3
* mozilla-inbound: 1
* mozilla-central: 1

Platform breakdown:
* windowsxp: 5

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1302917&startday=2016-10-31&endday=2016-11-06&tree=all

Comment 7

[Intermittent Failures Robot]

14 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 10
* mozilla-central: 2
* autoland: 2

Platform breakdown:
* windowsxp: 14

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1302917&startday=2016-11-07&endday=2016-11-13&tree=all

Comment 8

[Thomas Nguyen (:tnguyen)]

This seems block bug 1315386, I would like to take it

Comment 9

[Thomas Nguyen (:tnguyen)]

Attachment: Bug 1302917 - Call callback correctly to Fix intermittent test_streamupdater.js

Review commit: https://reviewboard.mozilla.org/r/94610/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94610/

Comment 10

[Thomas Nguyen (:tnguyen)]

Running try 1x time to see if the intermittent occurs
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb0463e6474e07012a827819fd9473d171b67aa1

Comment 11

[Thomas Nguyen (:tnguyen)]

Just remove the callback which calls to next_test without waiting for running result

Comment 12

[François Marier [:francois]]

Comment on attachment 8813091 [details]
Bug 1302917 - Call callback correctly to Fix intermittent test_streamupdater.js

https://reviewboard.mozilla.org/r/94610/#review95124

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22346c89219f
Call callback correctly to Fix intermittent test_streamupdater.js r=francois

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/22346c89219f

Comment 15

[Ethan Tseng [:ethan]]

Thomas, thanks for fixing this. Good job!

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7b1a218bce5c

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8c15d7857dce