1302926 - Report MP4Parse telemetry for all tracks, not just the first one

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Matthew Gregan [:kinetik]]

MP4Metadata::GetNumberTracks isn't correctly reporting telemetry for the Rust MP4 demuxer because mReportedTelemetry is set after the first call to GetNumberTracks, even if subsequent calls are for different track types.  I think this is causing MEDIA_RUST_MP4PARSE_TRACK_MATCH_VIDEO not to show up in the current telemetry at all.

The simple solution is to drop mReportedTelemetry and let the telemetry servers handle coalescing of results.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: bug1302926_v0.patch

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Or you could have a separate bool for each track type?

Comment 3

[Matthew Gregan [:kinetik]]

Attachment: bug1302926_v1.patch

Sure... but now you've volunteered to review it.

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8791471 [details] [diff] [review]
bug1302926_v1.patch

Review of attachment 8791471 [details] [diff] [review]:
-----------------------------------------------------------------

I'll take the punishment...

r+ with suggestion:

::: media/libstagefright/binding/include/mp4_demuxer/MP4Metadata.h
@@ +40,5 @@
>  #ifdef MOZ_RUST_MP4PARSE
>    UniquePtr<MP4MetadataRust> mRust;
>    mutable bool mPreferRust;
> +  mutable bool mReportedAudioTracks;
> +  mutable bool mReportedVideoTracks;

I feel like "Telemetry" should stay in the name, as it's not obvious in this context.
If you don't like ExtremelyLongVariableNames, please add a comment about telemetry instead.

Comment 5

[Matthew Gregan [:kinetik]]

I renamed them to mReported{Audio,Video}TrackTelemetry.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d6a57e1b12f
Report MP4Parse telemetry for all tracks, not just the first one.   r=gerald

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4d6a57e1b12f