Closed Bug 1302937 Opened 3 years ago Closed 3 years ago

Remove support for obsolete -moz-mac-lion-theme media query

Categories

(Core :: Widget: Cocoa, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: dao, Assigned: wisniewskit)

References

Details

Attachments

(1 file, 1 obsolete file)

We don't need -moz-mac-graphite-theme and -moz-mac-lion-theme anymore and should remove them.
Will this patch do, or is there more that should be removed?

A try run just in case: https://treeherder.mozilla.org/#/jobs?repo=try&revision=24b994516755
Attachment #8791859 - Flags: review?(b56girard)
Oops, I hadn't realized :-moz-system-metric(mac-graphite-theme) was still used since I only searched for -moz-mac-graphite-theme. Is this just dead code or is the "graphite" setting still a thing in recent OS X versions?
I don't have a Mac, but according to some tutorials online, Yosemite does have the ability to change its theme to a Graphite one: http://www.cultofmac.com/301007/hate-os-x-yosemites-look-heres-give-classic-makeover/
(In reply to Dão Gottwald [:dao] from comment #2)
> Oops, I hadn't realized :-moz-system-metric(mac-graphite-theme) was still
> used since I only searched for -moz-mac-graphite-theme. Is this just dead
> code or is the "graphite" setting still a thing in recent OS X versions?

No, it's not dead code, :-moz-system-metric(mac-graphite-theme) is still needed.
If I manage to fix the selections right in bug 1192053, the css using :-moz-system-metric(mac-graphite-theme) will go, but even then I think we should keep the media query since the graphite theme still exists on MacOS. It would be a waste of time removing it and re-implementing if someone needs the media query.
Okay, let's keep -moz-mac-graphite-theme.
Summary: Remove support for obsolete -moz-mac-graphite-theme and -moz-mac-lion-theme media queries → Remove support for obsolete -moz-mac-lion-theme media query
Alright, here's a new patch that just removes the lion theme.

Note that there are also references to Lion in browser/themes/osx/browser.css and browser/themes/osx/jar.mn, but I suspect that their use overlaps with Yosemite, so I left them as-is.
Attachment #8791859 - Attachment is obsolete: true
Attachment #8791859 - Flags: review?(b56girard)
Comment on attachment 8792073 [details] [diff] [review]
1302937-remove_-moz-mac-lion-theme.diff

Oops, forgot to request review on the updated patch.
Attachment #8792073 - Flags: review?(b56girard)
Comment on attachment 8792073 [details] [diff] [review]
1302937-remove_-moz-mac-lion-theme.diff

Review of attachment 8792073 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review. This looks good.

(Benoit has left Mozilla, and I'm the one who added mac-lion-theme in bug 679717.)
Attachment #8792073 - Flags: review?(b56girard) → review+
Alright, thanks!

Requesting check-in.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3eb99e7b16d
Remove -moz-mac-lion-theme. r=mstange
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c3eb99e7b16d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Assignee: nobody → wisniewskit
Depends on: 1304008
You need to log in before you can comment on or make changes to this bug.