1302957 - Vimeo video content not playable without Fullscreen API support

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Affected versions]:
- latest Nightly 51.0a1 (2016-09-14)

[Affected platforms]:
- Windows 10 x64
- Ubuntu 16.04 x86
- Mac OS X 10.11

[Steps to reproduce]:
1. Launch Firefox
2. Go to https://vimeo.com/ and open a random video (e.g. https://vimeo.com/181907337)
3. Bookmark the chosen video
4. Open the Bookmarks Menu, look for the previous created bookmark and open its Properties (context menu option)
5. Check the "Load this bookmark in the sidebar" option and click the "Save" button
6. Open again the Bookmarks Menu and click the bookmark in question

[Expected result]:
- The chosen video item is properly loaded in the sidebar and no rendering issues are encountered

[Actual result]:
- The chosen video item is not loaded if it is open in the sidebar

[Regression range]:
* Last good revision: eb90834c4f107ebdeb369702d66e5257ff352d36
* First bad revision: 5aabb19fcdfe384ced77636f8556d3488e37d51f
* Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=eb90834c4f107ebdeb369702d66e5257ff352d36&tochange=5aabb19fcdfe384ced77636f8556d3488e37d51f

* Looks like the following bug has the changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=1299795

Comment 1

[Maire Reavy [:mreavy]]

Follow up on previous comment: "* Looks like the following bug has the changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=1299795", I'm needinfo'ing the owner of that bug.  

@xidorn - can you take a look at this?  Should we move this from Audio/Video:Playback to DOM?

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

It seems Vimeo video doesn't work if the Fullscreen API is disabled. If you set pref "full-screen-api.enabled" to false, you'll find that Vimeo video would not work even it is not in sidebar.

I think it is something Vimeo should fix, because there is no guarantee that Fullscreen API would always be available. Users may want to disable Fullscreen API for e.g. protecting their privacy.

So moving to Tech Evangelism.

Comment 3

[Mike Taylor [:miketaylr]]

I think the issue is in `_initAssets` and `_initPlayer` @ https://f.vimeocdn.com/js_opt/utils/player_manager/player_manager.min.js?55ab7083

function _initJunk() {
  if (usePlayer) {
    doStuff()
    return;
  }

  if (useFlash) {
    doStuff()
    return
  }
}

usePlayer looks like:

usePlayer = fullscreenSupport || IE10 && !flashSupport || windowsPhone;
And fullscreenSupport like so:

fullscreenSupport = document.fullscreenEnabled || document.webkitFullscreenEnabled || document.mozFullScreenEnabled || document.msFullscreenEnabled || videoFullscreenSupport;

So there's an early return and the player is never set up because `usePlayer` is never true w/o fullscreen API support.

Comment 4

[Mike Taylor [:miketaylr]]

Adam, do we have any Vimeo contacts?

Comment 5

[Karl Dubost💡 :karlcow]

We do.
Andrew, could you help us on this one?

Comment 6

[Desigan Chinniah [:cyberdees] [:dees] [London - GMT]]

(In reply to Mike Taylor [:miketaylr] from comment #4)
> Adam, do we have any Vimeo contacts?

Let's have a go via the discussion mailing list?

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Benjamin, did you have any insight here? Sounds like may be something to do with falling back to Flash which we may not support for fullscreen in the sidebar.

Comment 8

[Mike Taylor [:miketaylr]]

(to follow up, Overholt started a thread on our vimeo ML -- there is a question for bsmedberg to answer regarding flash support)

Comment 9

[Benjamin Smedberg]

Liz, I think comment 3 captures the problem here so I don't know what other information I can provide.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for a fix for 53, as we are in the last week of the 53 beta cycle.

Comment 11

[Adam Stevenson [:adamopenweb]]

I'm unable to reproduce this issue in Firefox 55 for OSX and Windows 10. The video takes a second to actually play in Windows, but it does work.

Without a screenshot I have nothing to compare to, but since the video is playing I think this is fixed. Please reopen if I'm missing something here. Thanks!