1302969 - [New Find Toolbar] Highlighting is broken on SVG pages

Status: NEW

(Toolkit :: Find Toolbar, defect)

Description

[Simona Badau, Desktop QA]

[Affected versions]:
- Nightly 51

[Affected platforms]:
- Windows 10, Ubuntu 16.04 and Mac OS X 10.11

[Steps to reproduce]:
1. Open Nightly (be sure you have "findbar.modalHighlight" and "findbar.highlightAll" set to true).
2. Go to this SVG page: https://bug1294843.bmoattachments.org/attachment.cgi?id=8780694
3. Press CTRL+F to open Find toolbar.
4. Search for any word that appears on the page (e.g "ion").

[Expected result]:
- The background is dimmed, the matches are highlighted, first one with a yellow background and the other ones with a high contrast background.

[Actual result]:
- The background is not dimmed
- the matches are not properly highlighted: 
  -- on Windows 10 the first match is not yellow, but becomes invisible as you type, and the rest off them are not highlighted at all
  -- on Ubuntu the first match term is written with white characters as you type, and the rest are not visible at all
  -- on Mac OS X - the highlight is not done at all

[Regression range]:
- I will investigate and post the results as soon as possible.

Comment 1

[Mike de Boer [:mikedeboer]]

This has _never_ worked before.

Comment 2

[Simona Badau, Desktop QA]

Attachment: NewFindToolbarOff.png

(In reply to Mike de Boer [:mikedeboer] from comment #1)
> This has _never_ worked before.

Please see the actual results that I get on Windows 10 when I set the preferences "findbar.modalHighlight" and "findbar.highlightAll" to false.

Comment 3

[Mike de Boer [:mikedeboer]]

Well, that's certainly a surprise to me. Looking into it.

Comment 4

[Daniel Bodea [:danibodea]]

After all this time since it was logged, some of the necessities were implemented and some expectancies have changed (in Nightly v88.0a1 and Beta v87.0b4):

[Expected result]:

• The background is dimmed, the matches are highlighted, the first one with a green (not yellow) background and the other ones with magenta

[Actual result]:

• The background is still not dimmed
• the matches are now properly highlighted with green and magenta
• moreover, the scrollbar highlights are also being displayed properly

Should we keep this bug open just for the page dimming effect?

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit auto_nag documentation.