1302975 - [Static Analysis][Uninitialized pointer field] In constructor Paint

Status: RESOLVED INVALID

(Core :: SVG, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that |mFrame| os not initialised in the default constructor. This should be fixed in order to integrate our un-initilisation checker based on clang-analysis

Comment 1

[Andi [:andi]]

Attachment: Bug 1302975 - initialise mFrame in Paint constructor.

Review commit: https://reviewboard.mozilla.org/r/78940/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78940/

Comment 2

[Robert Longson [:longsonr]]

Why isn't MOZ_INIT_OUTSIDE_CTOR enough here?

    // Initialized (if needed) in SetPaintServer():
    MOZ_INIT_OUTSIDE_CTOR nsIFrame* mFrame;

If we really need to rewrite this we need to remove that too.

Comment 3

[Andi [:andi]]

(In reply to Robert Longson from comment #2)
> Why isn't MOZ_INIT_OUTSIDE_CTOR enough here?
> 
>     // Initialized (if needed) in SetPaintServer():
>     MOZ_INIT_OUTSIDE_CTOR nsIFrame* mFrame;
> 
> If we really need to rewrite this we need to remove that too.

Ive noticed that was initialised in SetPaintServer like mPaintType, so i initialised it for consistency with mPaintType

Comment 4

[Robert Longson [:longsonr]]

It's not accessed if mPaintType is none.

Comment 5

[Andi [:andi]]

Comment on attachment 8791535 [details]
Bug 1302975 - initialise mFrame in Paint constructor.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/78940/diff/1-2/

Comment 6

[Robert Longson [:longsonr]]

Comment on attachment 8791535 [details]
Bug 1302975 - initialise mFrame in Paint constructor.

Just do a hg pull -u and you'll find the code already looks like this.

Comment 7

[Andi [:andi]]

yes just did this and the fix is there.