Make stylo reftest pass green

RESOLVED FIXED in Firefox 51

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: manishearth, Assigned: manishearth)

Tracking

unspecified
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8791561 - Flags: review?(manishearth)
Attachment #8791562 - Flags: review?(slyu)
(Assignee)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8791561 [details]
Bug 1302993 - Update some stylo reftest expectations;

https://reviewboard.mozilla.org/r/78966/#review77534

(First patch is Shing's patch. r=me)
Attachment #8791561 - Flags: review?(manishearth) → review+
(Assignee)

Comment 4

2 years ago
Pushed to try again, but https://treeherder.mozilla.org/#/jobs?repo=try&revision=0740a6371dca&selectedJob=27509360 is (mostly) the same changes, being almost green.
rs=me on these changes.

Comment 6

2 years ago
mozreview-review
Comment on attachment 8791561 [details]
Bug 1302993 - Update some stylo reftest expectations;

https://reviewboard.mozilla.org/r/78966/#review77982
Attachment #8791561 - Flags: review?(cam) → review+

Comment 7

2 years ago
mozreview-review
Comment on attachment 8791562 [details]
Bug 1302993 - Mark more expectations for stylo tests, make reftest-stylo green;

https://reviewboard.mozilla.org/r/78968/#review77984
Attachment #8791562 - Flags: review?(cam) → review+

Comment 8

2 years ago
Pushed by manishearth@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4335ede65ada
Update some stylo reftest expectations; r=heycam
https://hg.mozilla.org/integration/autoland/rev/d3e3c644160a
Mark more expectations for stylo tests, make reftest-stylo green; r=heycam

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4335ede65ada
https://hg.mozilla.org/mozilla-central/rev/d3e3c644160a
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51

Updated

2 years ago
Attachment #8791562 - Flags: review?(slyu)
Blocks: 1330414
You need to log in before you can comment on or make changes to this bug.