1303027 - Clean up seamonkey l10n configurations

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Axel Hecht [:Pike]]

There are a ton of old and unused l10n config files in suite/locales, we should remove them, and clean up the remaining files.

This is in preparation to some more extensive changes on how compare-locales works internally, and how it's configured in-tree.

Comment 1

[Axel Hecht [:Pike]]

Attachment: bug 1303027, clean up seamonkey l10n configurations,

Remove old configurations for 2.0.
Make filter.py return "ignore" and "error" to make it easier
to understand, also remove devtools/client for now.
Fix that for real in bug 1301940.

Review commit: https://reviewboard.mozilla.org/r/79046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79046/

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 8791748 [details]
bug 1303027, clean up seamonkey l10n configurations,

sorry for the noise, trying to get mozreview to do what I hope it to do.

Comment 3

[Ian Neal]

Comment on attachment 8791748 [details]
bug 1303027, clean up seamonkey l10n configurations,

https://reviewboard.mozilla.org/r/79044/#review77692

::: suite/locales/filter.py:25
(Diff revision 1)
>    if entity is None:
>      # missing and obsolete files
> -    return not (re.match(r"searchplugins\/.+\.xml", path) or
> +    return ("ignore" if (re.match(r"searchplugins\/.+\.xml", path) or
> -                re.match(r"chrome\/common\/help\/images\/[A-Za-z-_]+\.[a-z]+", path))
> +                         re.match(r"chrome\/common\/help\/images\/[A-Za-z-_]+\.[a-z]+", path))
> -  if path == "defines.inc":
> -    return entity != "MOZ_LANGPACK_CONTRIBUTORS"
> +            else "error")
> +  if path == "defines.inc" and entity == "MOZ_LANGPACK_CONTRIBUTORS":

Shouldn't this be something like:
if path == "defines.inc":
  return ("ignore" if (entity == "MOZ_LANGPACK_CONTRIBUTORS")
          else "error")
?

::: suite/locales/l10n.ini:21
(Diff revision 1)
> +# not working on a local check-out
>  toolkit = mozilla/toolkit/locales/l10n.ini
>  services_sync = mozilla/services/sync/locales/l10n.ini
>  
>  [extras]
> -dirs = mozilla/extensions/inspector
> +dirs = mozilla/extensions/spellcheck

Why is inspector being removed?

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 8791748 [details]
bug 1303027, clean up seamonkey l10n configurations,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79046/diff/1-2/

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 8791748 [details]
bug 1303027, clean up seamonkey l10n configurations,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79046/diff/2-3/

Comment 6

[Axel Hecht [:Pike]]

(In reply to Ian Neal from comment #3)
> Comment on attachment 8791748 [details]
> bug 1303027, clean up seamonkey l10n configurations,
> 
> https://reviewboard.mozilla.org/r/79044/#review77692
> 
> ::: suite/locales/filter.py:25
> (Diff revision 1)
> >    if entity is None:
> >      # missing and obsolete files
> > -    return not (re.match(r"searchplugins\/.+\.xml", path) or
> > +    return ("ignore" if (re.match(r"searchplugins\/.+\.xml", path) or
> > -                re.match(r"chrome\/common\/help\/images\/[A-Za-z-_]+\.[a-z]+", path))
> > +                         re.match(r"chrome\/common\/help\/images\/[A-Za-z-_]+\.[a-z]+", path))
> > -  if path == "defines.inc":
> > -    return entity != "MOZ_LANGPACK_CONTRIBUTORS"
> > +            else "error")
> > +  if path == "defines.inc" and entity == "MOZ_LANGPACK_CONTRIBUTORS":
> 
> Shouldn't this be something like:
> if path == "defines.inc":
>   return ("ignore" if (entity == "MOZ_LANGPACK_CONTRIBUTORS")
>           else "error")
> ?

Yes, fixed that 'cause it's more consistent.

> ::: suite/locales/l10n.ini:21
> (Diff revision 1)
> > +# not working on a local check-out
> >  toolkit = mozilla/toolkit/locales/l10n.ini
> >  services_sync = mozilla/services/sync/locales/l10n.ini
> >  
> >  [extras]
> > -dirs = mozilla/extensions/inspector
> > +dirs = mozilla/extensions/spellcheck
> 
> Why is inspector being removed?

Good question, made me remove more across the board.

[extra] is only used in the dashboard automation code, to trigger compare runs. It's not used by compare-locales internally at all. Not sure if it ever was.

Now, the paths coming in to the code never include the 'mozilla' prefix, so this is essentially a no-op.

Thus I removed both entries, and did so consistently across all ini files.

Comment 7

[Ian Neal]

Comment on attachment 8791748 [details]
bug 1303027, clean up seamonkey l10n configurations,

https://reviewboard.mozilla.org/r/79046/#review77924

Looks good to me

Comment 8

[Axel Hecht [:Pike]]

Landed with a=ewong from irc, https://hg.mozilla.org/comm-central/rev/f8b0b5f8d2ec.

Comment 9

[Robert Kaiser]

Is the devtools line intentionally being removed from l10n.ini?

Comment 10

[Axel Hecht [:Pike]]

Yes, I'd like to fix that in bug 1301940. TBH, I don't think this ever worked at all. I wonder how that didn't break people in real life yet.