Closed Bug 1303099 Opened 7 years ago Closed 7 years ago

LenientFloat should finish argument processing before bailing out

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file, 1 obsolete file)

With a web platform test
6.98 KB, patch
Details | Diff | Splinter Review
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8791733 [details] [diff] [review]
LenientFloat handling should not prevent all arguments being processed; instead it should just cause an early return right after argument processing

Review of attachment 8791733 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. Since this syncs us with everyone else, is this turning into a wpt?
Attachment #8791733 - Flags: review?(kyle) → review+
Yes, I'll add a test as soon as I make sure we don't have one already. ;) https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb9802a1e662 is checking that.
Attachment #8791733 - Attachment is obsolete: true
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f60f494e7d57
LenientFloat handling should not prevent all arguments being processed; instead it should just cause an early return right after argument processing.  r=qdot
https://hg.mozilla.org/mozilla-central/rev/f60f494e7d57
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.