Closed Bug 1303210 Opened 4 years ago Closed 4 years ago

Show compressed size in find_dupes.py report, and sort the output

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8791823 [details]
Bug 1303210 - Show compressed size in find_dupes.py report, and sort its output.

https://reviewboard.mozilla.org/r/79086/#review78248

::: toolkit/mozapps/installer/find-dupes.py:22
(Diff revision 1)
>  def find_dupes(source):
>      md5s = OrderedDict()
>      for p, f in UnpackFinder(source):
>          content = f.open().read()
>          m = hashlib.md5(content).digest()
>          if not m in md5s:

While you're here, please change this to `if m not in md5s:`
Attachment #8791823 - Flags: review?(gps) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/608b76d0900e
Show compressed size in find_dupes.py report, and sort its output. r=gps
https://hg.mozilla.org/mozilla-central/rev/608b76d0900e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.