Closed
Bug 1303223
Opened 8 years ago
Closed 8 years ago
Ensure that crates specify panic=abort in their Cargo.toml file
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox52 fixed)
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
Details
Attachments
(1 file)
|
8.27 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
MozReview-Commit-ID: GX0FJjDVA5q
Attachment #8791827 -
Flags: review?(nfroyd)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8791827 [details] [diff] [review] Ensure that panic = 'abort' is specified for all toplevel Cargo.tomls Review of attachment 8791827 [details] [diff] [review]: ----------------------------------------------------------------- r=me with the test noted below. ::: python/mozbuild/mozbuild/frontend/emitter.py @@ +453,5 @@ > + profile = profile_section.get(profile_name, None) > + if not profile: > + raise SandboxValidationError( > + 'Cargo.toml for %s has no [profile.%s] section' % (libname, profile_name), > + context) Can you add a test for this error?
Attachment #8791827 -
Flags: review?(nfroyd) → review+
Pushed by michael@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/11a51ab63f0e Ensure that panic = 'abort' is specified for all toplevel Cargo.tomls, r=froydnj
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/11a51ab63f0e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•