Closed Bug 1303223 Opened 5 years ago Closed 5 years ago

Ensure that crates specify panic=abort in their Cargo.toml file

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox52 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: nika, Assigned: nika)

Details

Attachments

(1 file)

Ensure that panic = 'abort' is specified for all toplevel Cargo.tomls
8.27 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
No description provided.
MozReview-Commit-ID: GX0FJjDVA5q
Attachment #8791827 - Flags: review?(nfroyd)
Comment on attachment 8791827 [details] [diff] [review]
Ensure that panic = 'abort' is specified for all toplevel Cargo.tomls

Review of attachment 8791827 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the test noted below.

::: python/mozbuild/mozbuild/frontend/emitter.py
@@ +453,5 @@
> +            profile = profile_section.get(profile_name, None)
> +            if not profile:
> +                raise SandboxValidationError(
> +                    'Cargo.toml for %s has no [profile.%s] section' % (libname, profile_name),
> +                    context)

Can you add a test for this error?
Attachment #8791827 - Flags: review?(nfroyd) → review+
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11a51ab63f0e
Ensure that panic = 'abort' is specified for all toplevel Cargo.tomls, r=froydnj
https://hg.mozilla.org/mozilla-central/rev/11a51ab63f0e
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.