1303223 - Ensure that crates specify panic=abort in their Cargo.toml file

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Ensure that panic = 'abort' is specified for all toplevel Cargo.tomls

MozReview-Commit-ID: GX0FJjDVA5q

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8791827 [details] [diff] [review]
Ensure that panic = 'abort' is specified for all toplevel Cargo.tomls

Review of attachment 8791827 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the test noted below.

::: python/mozbuild/mozbuild/frontend/emitter.py
@@ +453,5 @@
> +            profile = profile_section.get(profile_name, None)
> +            if not profile:
> +                raise SandboxValidationError(
> +                    'Cargo.toml for %s has no [profile.%s] section' % (libname, profile_name),
> +                    context)

Can you add a test for this error?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11a51ab63f0e
Ensure that panic = 'abort' is specified for all toplevel Cargo.tomls, r=froydnj

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/11a51ab63f0e