Comment on line 21 of FileSystemDirectoryEntry.webidl incorrect about what error is returned

RESOLVED FIXED in Firefox 52

Status

()

P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sheppy, Assigned: baku)

Tracking

50 Branch
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
The comment says "ErrorCallback will be called with NS_ERROR_DOM_NOT_SUPPORTED_ERR", but a look at the code shows:

  ErrorCallbackHelper::Call(GetParentObject(), aErrorCallback,
                            NS_ERROR_DOM_SECURITY_ERR);

The comment should be corrected to say that NS_ERROR_DOM_SECURITY_ERR is returned.
Component: Untriaged → DOM
baku, can you take a look?
Flags: needinfo?(amarchesini)
Priority: -- → P3
(Assignee)

Comment 2

2 years ago
Created attachment 8793654 [details] [diff] [review]
file_error.patch
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attachment #8793654 - Flags: review?(bugs)

Comment 3

2 years ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/89cf1ca5cf6c
Fixing comments in FileSystem webIDL files, r=smaug

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/89cf1ca5cf6c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.