Closed
Bug 1303301
Opened 6 years ago
Closed 6 years ago
Crash in mozilla::WebGLContext::ThrowEvent_WebGLContextCreationError
Categories
(Core :: Canvas: WebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla52
People
(Reporter: patclash, Assigned: sotaro)
References
Details
(Keywords: crash, regression, Whiteboard: [tbird topcrash])
Crash Data
Attachments
(1 file, 1 obsolete file)
859 bytes,
patch
|
sotaro
:
review+
gchang
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-ee0a42d9-8fe8-4e6b-b698-7e7fa2160916. ============================================================= Crash when open Troubleshooting Information since buildID=20160915004004 Reproducible : always Last build that don't crash is buildID=20160914004004
Comment 1•6 years ago
|
||
jorg or aceman might have a good guess at what's causing this, they are at the forefront of many of the changes :)
When Jorg fixed the troubleshooting page, it may now actually run the GPU tests needed to populate the page. I'd first run this through the core GPU guys as the stack looks like it may be a problem in WebGL core. Often probing GPU/OpenGL features may provoke driver bugs.
Component: General → Graphics
Product: Thunderbird → Core
Comment 3•6 years ago
|
||
(In reply to :aceman from comment #2) > When Jorg fixed the troubleshooting page, ... You know what? It was absolute synchronicity that bug 1281785 landed (fixed the graphics section) when I got graphics errors due to some overzealous reporting which has since been fixed in M-C (bug 1302713). Only due to this coincidence did I notice that errors weren't reported properly in TB's Troubleshooting Information.
Comment 4•6 years ago
|
||
#1 crash for https://crash-stats.mozilla.com/topcrashers/?product=Thunderbird&version=50.0a2
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [tbird topcrash]
![]() |
||
Comment 5•6 years ago
|
||
[Tracking Requested - why for this release]: [Tracking Requested - why for this release]: Regression window: Last Good: http://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-central-win32/1473799447/ First crash: http://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-central-win32/1473839167/ Pushlog: https://hg.mozilla.org/comm-central/pushloghtml?fromchange=c482d8a2cd6178a9e5990c07b6c7c09dc63d919d&tochange=44003aa9b4def847e79458ca5756e50c1f0032b3 https://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2016-09-13+13%3A00%3A00&enddate=2016-09-14+01%3A00%3A00 Regressed by: 77a72b7f61d4 Sotaro Ikeda — Bug 1281785 - JavaScript error: chrome://messenger/content/about-support/gfx.js, line 46: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]. r=mkmelin
Blocks: 1281785
status-firefox50:
--- → affected
status-firefox51:
--- → affected
tracking-firefox50:
--- → ?
tracking-firefox51:
--- → ?
Keywords: regressionwindow-wanted
![]() |
||
Comment 6•6 years ago
|
||
It is need to re-check after landing Bug 1303741 on m-c.
![]() |
||
Comment 7•6 years ago
|
||
s/Bug 1303741 on m-c/Bug 1300562 on c-c/
![]() |
||
Comment 8•6 years ago
|
||
Earlybird50.0a2: bp-40d34e0b-5a72-4201-bffc-210c92160919 Daily51.0a1: bp-c93dc2f9-badf-487a-8fd7-559852160919
![]() |
||
Updated•6 years ago
|
Flags: needinfo?(sotaro.ikeda.g)
![]() |
||
Comment 9•6 years ago
|
||
http://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-central-win32/1474300577/ https://hg.mozilla.org/comm-central/rev/a2836536b7e00825a6e108ecd749460d54498cd3 As I expected, the crash is back on latest c-c tinderbox build(incl the patch of bug 1300562).
Assignee | ||
Comment 10•6 years ago
|
||
nullptr dereference happened. It seems like a bug of WebGLContext::ThrowEvent_WebGLContextCreationError(). It expects canvas element or offscreen canvas.
Assignee | ||
Updated•6 years ago
|
Component: Graphics → Canvas: WebGL
Flags: needinfo?(sotaro.ikeda.g)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 11•6 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #10) > nullptr dereference happened. It seems like a bug of > WebGLContext::ThrowEvent_WebGLContextCreationError(). It expects canvas > element or offscreen canvas. When WebGLContext is called by GfxInfoWebGL::GetWebGLParameter(), the WebGLContext does not have canvas element nor offscreen canvas.
Assignee | ||
Comment 12•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #8792761 -
Flags: review?(jgilbert)
Tracked as it's a new issue in Fx50.
[Tracking Requested - why for this release]: (In reply to Ritu Kothari (:ritu) from comment #13) > Tracked as it's a new issue in Fx50. Ritu, I believe this is Thunderbird only crash.
Updated•6 years ago
|
Attachment #8792761 -
Flags: review?(jgilbert) → review?(mtseng)
Ooops my bad, don't think we need to track this from our side.
tracking-firefox50:
? → ---
tracking-firefox51:
+ → ---
Updated•6 years ago
|
Attachment #8792761 -
Flags: review?(mtseng) → review+
Comment 16•6 years ago
|
||
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ca17ce6a2c9a Add nullptr handling r=mtseng
Comment 17•6 years ago
|
||
backed out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=36694393&repo=mozilla-inbound
Flags: needinfo?(sotaro.ikeda.g)
Comment 18•6 years ago
|
||
Backout by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cb3ef16e7648 Backed out changeset ca17ce6a2c9a for gl3 test failures
Assignee | ||
Comment 19•6 years ago
|
||
(In reply to Carsten Book [:Tomcat] from comment #17) > backed out for failures like > https://treeherder.mozilla.org/logviewer.html#?job_id=36694393&repo=mozilla- > inbound Sorry, I did silly mistake :(
Flags: needinfo?(sotaro.ikeda.g)
Assignee | ||
Comment 20•6 years ago
|
||
Attachment #8792761 -
Attachment is obsolete: true
Assignee | ||
Updated•6 years ago
|
Attachment #8796405 -
Flags: review+
Assignee | ||
Comment 21•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=18a4f4a9ef5b
Comment 22•6 years ago
|
||
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/95a97f6e3abf Add nullptr handling r=mtseng
Comment 23•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/95a97f6e3abf
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment 24•6 years ago
|
||
This is a topcrash for TB51 - so can this be uplifted to 51?
Comment 25•6 years ago
|
||
Comment on attachment 8796405 [details] [diff] [review] patch - Add nullptr handling I'll try filling in the form, Sotaro-san can you help, please. Approval Request Comment [Feature/regressing bug #]: ? [User impact if declined]: CRASH!! [Describe test coverage new/current, TreeHerder]: Yes, covered by test-suite. [Risks and why]: Low, just added a null pointer check. [String/UUID change made/needed]: None.
Flags: needinfo?(sotaro.ikeda.g)
Attachment #8796405 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 26•6 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: Bug 1271478 and bug 1281785 [User impact if declined]: CRASH happens when using Thunderbird. [Describe test coverage new/current, TreeHerder]: Yes, covered by test-suite. [Risks and why]: Low, just added a null pointer check. [String/UUID change made/needed]: None.
Flags: needinfo?(sotaro.ikeda.g)
Assignee | ||
Comment 27•6 years ago
|
||
Actual bug was injected by Bug 1271478, but it was masked until bug 1281785 fix. Since bug 1281785 fix, the bug was exposed on Thunderbird and caused the crash.
Comment 28•6 years ago
|
||
Comment on attachment 8796405 [details] [diff] [review] patch - Add nullptr handling Fix a crash. Take it in 51 aurora.
Attachment #8796405 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•6 years ago
|
Comment 29•6 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/d3c4d153cd34
Reporter | ||
Comment 30•6 years ago
|
||
Just to thanks all : That bug is fixed in today build (20161007004005) :)
Reporter | ||
Comment 31•6 years ago
|
||
This fix does been ported to 50.0b1 too ! same crash on first try :(
Flags: needinfo?(sotaro.ikeda.g)
Reporter | ||
Comment 32•6 years ago
|
||
The crash report : https://crash-stats.mozilla.com/report/index/526ab20e-2ddc-4046-ba54-59bbf2161008
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(sotaro.ikeda.g)
Assignee | ||
Comment 33•6 years ago
|
||
Comment on attachment 8796405 [details] [diff] [review] patch - Add nullptr handling Approval Request Comment [Feature/regressing bug #]: Bug 1271478 and bug 1281785 [User impact if declined]: CRASH happens when using Thunderbird. [Describe test coverage new/current, TreeHerder]: Yes, covered by test-suite. [Risks and why]: Low, just added a null pointer check. [String/UUID change made/needed]: None.
Attachment #8796405 -
Flags: approval-mozilla-beta?
Comment on attachment 8796405 [details] [diff] [review] patch - Add nullptr handling Null check, crash fix, Beta50+
Attachment #8796405 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 35•6 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/372cbe11c92e
You need to log in
before you can comment on or make changes to this bug.
Description
•