Closed Bug 1303302 Opened 6 years ago Closed 6 years ago

Destructible check for refcounted type doesn't work with MSVC

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Platform:
Unspecified
Windows
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(1 file)

Bug 1303302 - Add IsDestructible trait in TypeTraits and use it for refcounted type static check.
58 bytes, text/x-review-board-request
froydnj
: review+
Details 
There is a static_assert check for ensuring that refcounted object doesn't have dangerous public destructor. But that check is only available with Clang and GCC. It should work with MSVC as well.
Comment on attachment 8791934 [details]
Bug 1303302 - Add IsDestructible trait in TypeTraits and use it for refcounted type static check.

https://reviewboard.mozilla.org/r/79204/#review77774
Attachment #8791934 - Flags: review?(nfroyd) → review+
Looks like that version doesn't work with GCC and Clang... I'll submit another version which is compatible with all.
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/60d0e1dbddc0
Add IsDestructible trait in TypeTraits and use it for refcounted type static check. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/60d0e1dbddc0
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Depends on: 1303602
You need to log in before you can comment on or make changes to this bug.