Closed
Bug 1303302
Opened 3 years ago
Closed 3 years ago
Destructible check for refcounted type doesn't work with MSVC
Categories
(Core :: XPCOM, defect)
Not set
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(1 file)
There is a static_assert check for ensuring that refcounted object doesn't have dangerous public destructor. But that check is only available with Clang and GCC. It should work with MSVC as well.
| Comment hidden (mozreview-request) |
|
||
Comment 2•3 years ago
|
||
| mozreview-review | ||
Comment on attachment 8791934 [details] Bug 1303302 - Add IsDestructible trait in TypeTraits and use it for refcounted type static check. https://reviewboard.mozilla.org/r/79204/#review77774
Attachment #8791934 -
Flags: review?(nfroyd) → review+
|
Assignee | |
Comment 3•3 years ago
|
||
Looks like that version doesn't work with GCC and Clang... I'll submit another version which is compatible with all.
| Comment hidden (mozreview-request) |
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/60d0e1dbddc0 Add IsDestructible trait in TypeTraits and use it for refcounted type static check. r=froydnj
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/60d0e1dbddc0
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•