Closed
Bug 1303392
Opened 8 years ago
Closed 7 years ago
'Shift' in tooltip for color swatch should have an uppercase 'S'
Categories
(DevTools :: Inspector: Rules, defect, P3)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: sebo, Assigned: sebo)
References
Details
Attachments
(1 file)
|
1.64 KB,
patch
|
gl
:
review+
|
Details | Diff | Splinter Review |
The tooltip rule.colorSwatch.tooltip implemented in https://hg.mozilla.org/mozilla-central/rev/640f046e0e79 should write 'Shift' with an uppercase 'S' to be consistent with other keyboard shortcut spellings. Sebastian
|
||
Updated•8 years ago
|
Priority: -- → P2
|
|
||
Updated•8 years ago
|
Priority: P2 → P3
|
Assignee | |
Comment 1•7 years ago
|
||
|
||
Updated•7 years ago
|
Attachment #8900946 -
Flags: review?(gl) → review+
|
|
Assignee | |
Comment 2•7 years ago
|
||
Gabriel, can you please land the patch for me? It seems I don't have the rights to do that. Sebastian
Flags: needinfo?(gl)
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/57b909b82237 Used uppercase 'S' for 'Shift' in color swatch title r=gl
|
|
||
Updated•7 years ago
|
Flags: needinfo?(gl)
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/57b909b82237
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•