1303479 - Intermittent browser/modules/test/browser_UnsubmittedCrashHandler.js | Uncaught exception - at :206 - NotFoundError: Node was not found

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=36013538&repo=mozilla-inbound

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-linux-debug/1474045996/mozilla-inbound_ubuntu32_vm-debug_test-mochitest-browser-chrome-2-bm06-tests1-linux32-build2.txt.gz

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Ah, I think we need to wait for the notification node to show up here:

http://searchfox.org/mozilla-central/rev/8910ca900f826a9b714607fd23bfa1b37a191eca/browser/modules/test/browser_UnsubmittedCrashHandler.js#498

Because the call to UnsubmittedCrashHandler.init() kicks off the UnsubmittedCrashHandler.checkForUnsubmittedCrashReports(), which is async! So the node might not be ready by the time the test proceeds.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1303479 - Remove <xul:notification>s right away in browser_UnsubmittedCrashHandler.js to avoid intermittent.

Review commit: https://reviewboard.mozilla.org/r/80146/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80146/

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8793400 [details]
Bug 1303479 - Remove <xul:notification>s right away in browser_UnsubmittedCrashHandler.js to avoid intermittent.

https://reviewboard.mozilla.org/r/80146/#review78844

rs=me.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c160c2c7ae9
Remove <xul:notification>s right away in browser_UnsubmittedCrashHandler.js to avoid intermittent. r=florian

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9c160c2c7ae9

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/04669583b577