1303497 - Intermittent test_window_management.py TestSwitchWindow.test_windows | TimeoutException: Timed out after 5.1 seconds with message: The new window has not been opened.

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=3642929&repo=autoland

https://archive.mozilla.org/pub/firefox/tinderbox-builds/autoland-macosx64/1474061777/autoland_yosemite_r7_test-marionette-e10s-bm132-tests1-macosx-build105.txt.gz

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

17:44:40    ERROR -  TEST-UNEXPECTED-ERROR | test_window_management.py TestSwitchWindow.test_windows | TimeoutException: Timed out after 5.1 seconds with message: The new window has not been opened.
17:44:40     INFO -  Traceback (most recent call last):
17:44:40     INFO -    File "/builds/slave/test/build/venv/lib/python2.7/site-packages/marionette/marionette_test/testcases.py", line 162, in run
17:44:40     INFO -      testMethod()
17:44:40     INFO -    File "/builds/slave/test/build/tests/marionette/tests/testing/marionette/harness/marionette/tests/unit/test_window_management.py", line 46, in test_windows
17:44:40     INFO -      message="The new window has not been opened.")
17:44:40     INFO -    File "/builds/slave/test/build/venv/lib/python2.7/site-packages/marionette_driver/wait.py", line 151, in until
17:44:40     INFO -      cause=last_exc)

https://dxr.mozilla.org/mozilla-central/rev/f0f15b7c6aa77a0c5750918aa0a1cb3dc82185bc/testing/marionette/harness/marionette/tests/unit/test_window_management.py#42

Ups, we only get the now available window handles before the call to Wait().until(). It means that we never recognize if the window opens lazely.

Comment 2

[Gabor Krizsanits (INACTIVE)]

With e10s-multi this becomes perma orange... Could you give me some advice how to fix this? (I'm not familiar with these python based tests)

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I can quickly patch that and hope it will fix the e10s-multi case too.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1303497 - Fix failure in test_window_management.py for new window checks.

Review commit: https://reviewboard.mozilla.org/r/80424/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80424/

Comment 5

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8793746 [details]
Bug 1303497 - Fix failure in test_window_management.py for new window checks.

https://reviewboard.mozilla.org/r/80424/#review79098

Your changes look good, but I noticed another problem with window switching just below.

::: testing/marionette/harness/marionette/tests/unit/test_window_management.py:53
(Diff revision 1)
> -        #switch to another window
> +        # switch to another window
>          self.marionette.switch_to_window(new_win)

new_win == orig_win, so you don't actually switch to another window.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8793746 [details]
Bug 1303497 - Fix failure in test_window_management.py for new window checks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/80424/diff/1-2/

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8793746 [details]
Bug 1303497 - Fix failure in test_window_management.py for new window checks.

https://reviewboard.mozilla.org/r/80424/#review79098

I fixed that and added some more checks to ensure we do the correct things in this very basic window test. More refactoring will come with bug 1259055.

Comment 8

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8793746 [details]
Bug 1303497 - Fix failure in test_window_management.py for new window checks.

https://reviewboard.mozilla.org/r/80424/#review79112

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70c6f01a830b
Fix failure in test_window_management.py for new window checks. r=maja_zf

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/70c6f01a830b

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Looks like we have no regressions on autoland and mozilla-central. So lets get it uplifted to fix the failures on aurora and beta.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b57b64179109

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/30c48aa0402d

Comment 14

[BMO Automation]

Moving bug to Testing::Marionette Client and Harness component per bug 1815831.