Closed
Bug 1303522
Opened 8 years ago
Closed 8 years ago
../../../../workspace/gecko/android-ndk/sources/cxx-stl/llvm-libc++/libcxx/include/memory:2630:34: error: invalid conversion from 'std::__ndk1::unique_ptr<std::__ndk1::__function::__base<const unsigned char*(unsigned int)>, std::__ndk1::__allocator_destr
Categories
(Firefox OS Graveyard :: GonkIntegration, defect)
Tracking
(firefox52 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: gerard-majax, Unassigned)
References
Details
Attachments
(1 file)
Reporter | ||
Comment 1•8 years ago
|
||
That looks ... strange. Is it possible that this is coming from the use of NDK 11b ?
Flags: needinfo?(xidorn+moz)
Flags: needinfo?(nfroyd)
Comment hidden (mozreview-request) |
Comment 3•8 years ago
|
||
I suspect that change triggers some compiler bug... Hopefully updating NDK works.
Flags: needinfo?(xidorn+moz)
Reporter | ||
Comment 4•8 years ago
|
||
(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #3) > I suspect that change triggers some compiler bug... Hopefully updating NDK > works. Ok, I have pushed an updated version of the NDK 12b for B2G (we need this because the platforms and Android API versions included in the tooltool file for Android build are not complete for B2G ; that maybe should be merged). https://treeherder.mozilla.org/#/jobs?repo=try&revision=288348c217eb&filter-tier=1&filter-tier=2&filter-tier=3
Reporter | ||
Comment 5•8 years ago
|
||
Same with NDK 12b :( https://treeherder.mozilla.org/#/jobs?repo=try&revision=288348c217eb&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=27599179 I don't even understand the failure
Flags: needinfo?(nfroyd) → needinfo?(xidorn+moz)
Reporter | ||
Comment 6•8 years ago
|
||
Just found about: https://codereview.chromium.org/2108263003 would make me think this is related to Skia itself :(
Reporter | ||
Comment 7•8 years ago
|
||
Reland of the upstream patch that generated the same error might give us a clue: https://codereview.chromium.org/2134693002
Reporter | ||
Comment 8•8 years ago
|
||
Their fix being: https://skia.googlesource.com/skia/+/f48c62fa6ae703f0e4fa7b97a381eb06afaadc4b
Comment hidden (mozreview-request) |
Reporter | ||
Comment 10•8 years ago
|
||
I changed a little bit the |defined()| conditions to make sure this was kicking only on B2G but for any B2G ; we can improve it of course :)
Reporter | ||
Comment 11•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f872214b64b5&filter-tier=1&filter-tier=2&filter-tier=3
Comment 12•8 years ago
|
||
I don't really have any idea about this issue... Looks like you've found the solution. Canceling ni?
Flags: needinfo?(xidorn+moz)
Reporter | ||
Comment 13•8 years ago
|
||
(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #12) > I don't really have any idea about this issue... Looks like you've found the > solution. Canceling ni? Yep, thanks, sorry for the noise. Checked locally, the Z3c KK build works.
Reporter | ||
Comment 14•8 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #11) > https://treeherder.mozilla.org/#/jobs?repo=try&revision=f872214b64b5&filter- > tier=1&filter-tier=2&filter-tier=3 green
Comment 15•8 years ago
|
||
mozreview-review |
Comment on attachment 8792196 [details] Bug 1303522 - Include Skia libc++ workaround (https://codereview.chromium.org/2134693002) https://reviewboard.mozilla.org/r/79390/#review77962
Attachment #8792196 -
Flags: review?(lsalzman) → review+
Comment 16•8 years ago
|
||
Pushed by alissy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/948c8cc4b5d0 Include Skia libc++ workaround (https://codereview.chromium.org/2134693002) r=lsalzman
Comment 17•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/948c8cc4b5d0
You need to log in
before you can comment on or make changes to this bug.
Description
•