1303581 - Intermittent toolkit/mozapps/update/tests/unit_service_updater/marCallbackAppSuccessPartialSvc_win.js | checkServiceUpdateFinished - [checkServiceUpdateFinished : 2441] the update status should equal the expected value - "pending-service" == "succeeded"

Status: RESOLVED WORKSFORME

(Toolkit :: Application Update, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=36058308&repo=mozilla-inbound

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win32-pgo/1474151422/mozilla-inbound_xp_ix_test_pgo-xpcshell-bm119-tests1-windows-build153.txt.gz

Comment 1

[Robert Strong (they/them - no direct email)]

This looks like there may be a race condition with setting the value in update.status

18:01:05     INFO -  "18:01:02:975 | TEST-INFO | ../data/xpcshellUtilsAUS.js | [RU_LC_FE : 1664] The updater.exe application contains the Mozilla updater identity."
18:01:05     INFO -  "18:01:02:975 | TEST-INFO | ../data/xpcshellUtilsAUS.js | [RU_LC_FE : 1664] *** Warning: Could not open key.  (2)***"
18:01:05     INFO -  "18:01:02:976 | TEST-INFO | ../data/xpcshellUtilsAUS.js | [RU_LC_FE : 1664] *** Warning: Fallback key present, skipping VerifyCertificateTrustForFile check and the certificate attribute registry matching check.***"
18:01:05     INFO -  "18:01:02:976 | TEST-INFO | ../data/xpcshellUtilsAUS.js | [RU_LC_FE : 1664] Starting update process as the service in session 0."
18:01:05     INFO -  "18:01:02:976 | TEST-INFO | ../data/xpcshellUtilsAUS.js | [RU_LC_FE : 1664] Starting service with cmdline: "C:/Program Files/Mozilla Maintenance Service/update/updater.exe" "C:/Documents and Settings/cltbld.T-XP32-IX-165/Local Settings/Application Data/Mozilla/updates/marCallbackAppSuccessCompleteSvc_win/updates/0" C:/slave/test/build/tests/xpcshell/tests/toolkit/mozapps/update/tests/unit_service_updater/marCallbackAppSuccessCompleteSvc_win/dir.app C:/slave/test/build/tests/xpcshell/tests/toolkit/mozapps/update/tests/unit_service_updater/marCallbackAppSuccessCompleteSvc_win/dir.app 5768 C:/slave/test/build/tests/xpcshell/tests/toolkit/mozapps/update/tests/unit_service_updater C:/slave/test/build/tests/xpcshell/tests/toolkit/mozapps/update/tests/unit_service_updater/marCallbackAppSuccessCompleteSvc_win/dir.app/firefox.exe -no-remote -test-process-updates -dump-args C:/slave/test/build/tests/xpcshell/tests/toolkit/mozapps/update/tests/unit_service_updater/marCallbackAppSuccessCompleteSvc_win_app_args_log"
18:01:05     INFO -  "18:01:02:977 | TEST-INFO | ../data/xpcshellUtilsAUS.js | [RU_LC_FE : 1664] Process was started... waiting on result."
18:01:05     INFO -  "18:01:02:977 | TEST-INFO | ../data/xpcshellUtilsAUS.js | [RU_LC_FE : 1664] Process finished with return code 0."
18:01:05     INFO -  "18:01:02:977 | TEST-INFO | ../data/xpcshellUtilsAUS.js | [RU_LC_FE : 1664] updater.exe returned status: succeeded"
18:01:05     INFO -  "18:01:02:977 | TEST-INFO | ../data/xpcshellUtilsAUS.js | [RU_LC_FE : 1664] "
18:01:05     INFO -  "18:01:02:977 | TEST-INFO | ../data/xpcshellUtilsAUS.js | [RU_LC_FE : 1664] updater.exe was launched and run successfully!"
18:01:05     INFO -  "18:01:02:977 | TEST-INFO | ../data/xpcshellUtilsAUS.js | [RU_LC_FE : 1664] Service command software-update complete."
18:01:05     INFO -  "18:01:02:977 | TEST-INFO | ../data/xpcshellUtilsAUS.js | [RU_LC_FE : 1664] service command MozillaMaintenance complete with result: Success."
18:01:05     INFO -  "18:01:02:978 | TEST-INFO | ../data/xpcshellUtilsAUS.js | [RU_LC_FE : 1664] "
18:01:05  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/unit_service_updater/marCallbackAppSuccessPartialSvc_win.js | checkServiceUpdateFinished - [checkServiceUpdateFinished : 2441] the update status should equal the expected value - "pending-service" == "succeeded"
18:01:05     INFO -  ../data/xpcshellUtilsAUS.js:checkServiceUpdateFinished:2441

Comment 2

[Robert Strong (they/them - no direct email)]

Actually, it looks like the maintenance service wasn't launched since the last maintenance service log was for marCallbackAppSuccessCompleteSvc_win and the failure is for marCallbackAppSuccessPartialSvc_win

Comment 3

[Robert Strong (they/them - no direct email)]

No failures in a very long time.