Closed Bug 1303619 Opened 8 years ago Closed 7 years ago

Applying no-negated-condition rule changed meaning in calExtract.jsm

Categories

(Calendar :: Internal Components, defect)

Product:
Calendar
Component:
Internal Components
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: merike, Assigned: MakeMyDay)

References

Details

(Keywords: regression)

Attachments

(1 file)

FixBug1303619.diff
1.19 KB, patch
merike
: review+
Fallen
: approval-calendar-aurora+
Details | Diff | Splinter Review 
Here http://hg.mozilla.org/comm-central/diff/b4abc816a8b4/calendar/base/modules/calExtract.jsm#l1.53 when start.hour is 0 and start.minute is any other number.

Didn't check rest of the changes for that rule. There may be other similar cases.
Keywords: regression
Blocks: ltn54
Attached patch FixBug1303619.diff — — Splinter Review 
Ok, let's fix that. I have been looking at the mentioned patch again and there seems to be no further unwanted change in there.
Assignee: nobody → makemyday
Status: NEW → ASSIGNED
Attachment #8826851 - Flags: review?(merikes.lists)
Comment on attachment 8826851 [details] [diff] [review]
FixBug1303619.diff

I was a bit suspicious if at this point start.hour can be null, but apparently guessStart() takes care that it never is. So this should do it :)
Attachment #8826851 - Flags: review?(merikes.lists) → review+
Thanks. This is the date only case - guessStart doesn't add the hour property in this case.
Attachment #8826851 - Flags: approval-calendar-aurora?(philipp)
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/b1e7c35b6e09699c5a4aa731874c043983dfef71
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 5.5
Attachment #8826851 - Flags: approval-calendar-aurora?(philipp) → approval-calendar-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: