Closed Bug 1303655 Opened 6 years ago Closed 6 years ago

Move some code to DecodingState

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(3 files)

No description provided.
Assignee: nobody → jwwang
Blocks: 1295892
Priority: -- → P3
Attachment #8792381 - Flags: review?(kikuo)
Attachment #8792382 - Flags: review?(kikuo)
Attachment #8792383 - Flags: review?(kikuo)
Comment on attachment 8792381 [details]
Bug 1303655. Part 1 - Move some code to Decodingstate::Enter().

https://reviewboard.mozilla.org/r/79456/#review78088
Attachment #8792381 - Flags: review?(kikuo) → review+
Comment on attachment 8792382 [details]
Bug 1303655. Part 2 - Remove unused functions.

https://reviewboard.mozilla.org/r/79458/#review78090
Attachment #8792382 - Flags: review?(kikuo) → review+
Comment on attachment 8792383 [details]
Bug 1303655. Part 3 - Move mDecodeStartTime into Decodingstate.

https://reviewboard.mozilla.org/r/79460/#review78306

::: dom/media/MediaDecoderStateMachine.cpp:2750
(Diff revision 1)
>      StopPlayback();
>    }
>  
> -  TimeDuration decodeDuration = TimeStamp::Now() - mDecodeStartTime;
>    mBufferingStart = TimeStamp::Now();
>  

Hi JW, sorry for the late review against this patch, I've checked on dxr & searchfox, there's still codes related to quickbuffering around here.  In this patch, it seems gone. Though the modification here is quite simple, could you provide me the bug in which quickbuffering is removed for reference ?  Thanks
There is bug 1300711.
Comment on attachment 8792383 [details]
Bug 1303655. Part 3 - Move mDecodeStartTime into Decodingstate.

https://reviewboard.mozilla.org/r/79460/#review78306

> Hi JW, sorry for the late review against this patch, I've checked on dxr & searchfox, there's still codes related to quickbuffering around here.  In this patch, it seems gone. Though the modification here is quite simple, could you provide me the bug in which quickbuffering is removed for reference ?  Thanks

Bug 1300711 and its dependency are already landed to autoland.
Comment on attachment 8792383 [details]
Bug 1303655. Part 3 - Move mDecodeStartTime into Decodingstate.

https://reviewboard.mozilla.org/r/79460/#review78402

Cool !
Attachment #8792383 - Flags: review?(kikuo) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5a3a0a0bbeb
Part 1 - Move some code to Decodingstate::Enter(). r=kikuo
https://hg.mozilla.org/integration/autoland/rev/9d5e92f8ac82
Part 2 - Remove unused functions. r=kikuo
https://hg.mozilla.org/integration/autoland/rev/ef4cc44fdb1d
Part 3 - Move mDecodeStartTime into Decodingstate. r=kikuo
You need to log in before you can comment on or make changes to this bug.