Move some code to DecodingState

RESOLVED FIXED in Firefox 52

Status

()

P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(3 attachments)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
Assignee: nobody → jwwang
Blocks: 1295892
Priority: -- → P3
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8792381 - Flags: review?(kikuo)
Attachment #8792382 - Flags: review?(kikuo)
Attachment #8792383 - Flags: review?(kikuo)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8792381 [details]
Bug 1303655. Part 1 - Move some code to Decodingstate::Enter().

https://reviewboard.mozilla.org/r/79456/#review78088
Attachment #8792381 - Flags: review?(kikuo) → review+

Comment 5

2 years ago
mozreview-review
Comment on attachment 8792382 [details]
Bug 1303655. Part 2 - Remove unused functions.

https://reviewboard.mozilla.org/r/79458/#review78090
Attachment #8792382 - Flags: review?(kikuo) → review+

Comment 6

2 years ago
mozreview-review
Comment on attachment 8792383 [details]
Bug 1303655. Part 3 - Move mDecodeStartTime into Decodingstate.

https://reviewboard.mozilla.org/r/79460/#review78306

::: dom/media/MediaDecoderStateMachine.cpp:2750
(Diff revision 1)
>      StopPlayback();
>    }
>  
> -  TimeDuration decodeDuration = TimeStamp::Now() - mDecodeStartTime;
>    mBufferingStart = TimeStamp::Now();
>  

Hi JW, sorry for the late review against this patch, I've checked on dxr & searchfox, there's still codes related to quickbuffering around here.  In this patch, it seems gone. Though the modification here is quite simple, could you provide me the bug in which quickbuffering is removed for reference ?  Thanks
(Assignee)

Comment 7

2 years ago
There is bug 1300711.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 11

2 years ago
mozreview-review-reply
Comment on attachment 8792383 [details]
Bug 1303655. Part 3 - Move mDecodeStartTime into Decodingstate.

https://reviewboard.mozilla.org/r/79460/#review78306

> Hi JW, sorry for the late review against this patch, I've checked on dxr & searchfox, there's still codes related to quickbuffering around here.  In this patch, it seems gone. Though the modification here is quite simple, could you provide me the bug in which quickbuffering is removed for reference ?  Thanks

Bug 1300711 and its dependency are already landed to autoland.

Comment 12

2 years ago
mozreview-review
Comment on attachment 8792383 [details]
Bug 1303655. Part 3 - Move mDecodeStartTime into Decodingstate.

https://reviewboard.mozilla.org/r/79460/#review78402

Cool !
Attachment #8792383 - Flags: review?(kikuo) → review+
(Assignee)

Comment 13

2 years ago
Thanks!

Comment 14

2 years ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5a3a0a0bbeb
Part 1 - Move some code to Decodingstate::Enter(). r=kikuo
https://hg.mozilla.org/integration/autoland/rev/9d5e92f8ac82
Part 2 - Remove unused functions. r=kikuo
https://hg.mozilla.org/integration/autoland/rev/ef4cc44fdb1d
Part 3 - Move mDecodeStartTime into Decodingstate. r=kikuo

Comment 15

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d5a3a0a0bbeb
https://hg.mozilla.org/mozilla-central/rev/9d5e92f8ac82
https://hg.mozilla.org/mozilla-central/rev/ef4cc44fdb1d
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.