1303655 - Move some code to DecodingState

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1303655. Part 1 - Move some code to Decodingstate::Enter().

Review commit: https://reviewboard.mozilla.org/r/79456/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79456/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1303655. Part 2 - Remove unused functions.

Review commit: https://reviewboard.mozilla.org/r/79458/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79458/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1303655. Part 3 - Move mDecodeStartTime into Decodingstate.

Review commit: https://reviewboard.mozilla.org/r/79460/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79460/

Comment 4

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8792381 [details]
Bug 1303655. Part 1 - Move some code to Decodingstate::Enter().

https://reviewboard.mozilla.org/r/79456/#review78088

Comment 5

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8792382 [details]
Bug 1303655. Part 2 - Remove unused functions.

https://reviewboard.mozilla.org/r/79458/#review78090

Comment 6

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8792383 [details]
Bug 1303655. Part 3 - Move mDecodeStartTime into Decodingstate.

https://reviewboard.mozilla.org/r/79460/#review78306

::: dom/media/MediaDecoderStateMachine.cpp:2750
(Diff revision 1)
>      StopPlayback();
>    }
>  
> -  TimeDuration decodeDuration = TimeStamp::Now() - mDecodeStartTime;
>    mBufferingStart = TimeStamp::Now();
>  

Hi JW, sorry for the late review against this patch, I've checked on dxr & searchfox, there's still codes related to quickbuffering around here.  In this patch, it seems gone. Though the modification here is quite simple, could you provide me the bug in which quickbuffering is removed for reference ?  Thanks

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

There is bug 1300711.

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8792381 [details]
Bug 1303655. Part 1 - Move some code to Decodingstate::Enter().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79456/diff/1-2/

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8792382 [details]
Bug 1303655. Part 2 - Remove unused functions.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79458/diff/1-2/

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8792383 [details]
Bug 1303655. Part 3 - Move mDecodeStartTime into Decodingstate.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79460/diff/1-2/

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8792383 [details]
Bug 1303655. Part 3 - Move mDecodeStartTime into Decodingstate.

https://reviewboard.mozilla.org/r/79460/#review78306

> Hi JW, sorry for the late review against this patch, I've checked on dxr & searchfox, there's still codes related to quickbuffering around here.  In this patch, it seems gone. Though the modification here is quite simple, could you provide me the bug in which quickbuffering is removed for reference ?  Thanks

Bug 1300711 and its dependency are already landed to autoland.

Comment 12

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8792383 [details]
Bug 1303655. Part 3 - Move mDecodeStartTime into Decodingstate.

https://reviewboard.mozilla.org/r/79460/#review78402

Cool !

Comment 13

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5a3a0a0bbeb
Part 1 - Move some code to Decodingstate::Enter(). r=kikuo
https://hg.mozilla.org/integration/autoland/rev/9d5e92f8ac82
Part 2 - Remove unused functions. r=kikuo
https://hg.mozilla.org/integration/autoland/rev/ef4cc44fdb1d
Part 3 - Move mDecodeStartTime into Decodingstate. r=kikuo

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d5a3a0a0bbeb
https://hg.mozilla.org/mozilla-central/rev/9d5e92f8ac82
https://hg.mozilla.org/mozilla-central/rev/ef4cc44fdb1d