44 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
All the fields in the Details tab have a tool-tip... except for "Build Architecture". If I change webapp-django/crashstats/crashstats/jinja2/crashstats/report_index.html so that the "Build Architecture" title uses `fields_desc['processed_crash.cpu_name']` instead of `fields_desc['processed_crash.cpu_arch']` then I get a tool-tip. But I'm not sure if that's the right thing to do -- I looked at https://crash-stats.mozilla.com/api/SuperSearchFields/ and the cpu_name vs. cpu_arch situation is confusing. Adrian, do you know if this is the right thing to do?
See https://bugzilla.mozilla.org/show_bug.cgi?id=1303758#c4 for explanations about cpu_arch vs cpu_info. The problem you are seeing makes sense: the `fields_desc` dict uses `in_database_name` for its keys, and there is no `cpu_arch` key in our database, only `cpu_name`. So what you did in your testing is the right thing to do to fix this problem!
Created attachment 8792712 [details] [review] Link to Github pull-request: https://github.com/mozilla/socorro/pull/3476
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/9449a27b7c8b08882632ed1713ed32839ed73f8e Fixes bug 1303657 by fixing the "Build Architecture" tooltip. (#3476)
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.