1303665 - Move some code to CompletedState

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1303665. Part 1 - Move StepCompleted() into CompletedState::Step().

Review commit: https://reviewboard.mozilla.org/r/80036/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80036/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1303665. Part 2 - Move mSentPlaybackEndedEvent into CompletedState.

Review commit: https://reviewboard.mozilla.org/r/80038/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80038/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8793231 [details]
Bug 1303665. Part 1 - Move StepCompleted() into CompletedState::Step().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/80036/diff/1-2/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8793232 [details]
Bug 1303665. Part 2 - Move mSentPlaybackEndedEvent into CompletedState.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/80038/diff/1-2/

Comment 5

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8793232 [details]
Bug 1303665. Part 2 - Move mSentPlaybackEndedEvent into CompletedState.

https://reviewboard.mozilla.org/r/80038/#review79030

Comment 6

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8793231 [details]
Bug 1303665. Part 1 - Move StepCompleted() into CompletedState::Step().

https://reviewboard.mozilla.org/r/80036/#review79028

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4d23acba1de
Part 1 - Move StepCompleted() into CompletedState::Step(). r=kikuo
https://hg.mozilla.org/integration/autoland/rev/28a35f4aa671
Part 2 - Move mSentPlaybackEndedEvent into CompletedState. r=kikuo

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e4d23acba1de
https://hg.mozilla.org/mozilla-central/rev/28a35f4aa671