Closed Bug 1303688 Opened 3 years ago Closed 3 years ago

Baldr: MIPS: Take advantage of guard page to simplify asm.js/wasm memory access

Categories

(Core :: JavaScript Engine: JIT, defect)

Other
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: hev, Assigned: hev)

Details

Attachments

(2 files, 1 obsolete file)

See Bug 1298202
Attachment #8792744 - Flags: review?(luke)
Attachment #8792744 - Flags: review?(luke)
Attachment #8792744 - Attachment is obsolete: true
Attachment #8792846 - Flags: review?(luke)
Comment on attachment 8792846 [details] [diff] [review]
0001-Bug-1303688-Baldr-MIPS-Take-advantage-of-guard-page-.patch

Review of attachment 8792846 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, and sorry for the churn.

::: js/src/jit/mips-shared/CodeGenerator-mips-shared.cpp
@@ -1779,4 @@
>        default: MOZ_CRASH("unexpected array type");
>      }
>  
> -    memoryBarrier(mir->barrierBefore());

These were removed from the AsmJS* operations because atomics were changed into WasmLoad/Store.  Currently, these two nodes assert there is no barrier, so you'll need to remove those asserts and add the barriers.
Attachment #8792846 - Flags: review?(luke) → review+
Pushed by r@hev.cc:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e7561636a36
Baldr: MIPS: Take advantage of guard page to simplify asm.js/wasm memory access. r=luke
Pushed by r@hev.cc:
https://hg.mozilla.org/integration/mozilla-inbound/rev/415c88053edd
Baldr: MIPS: Move memory barrier to WasmLoad/Store. r=luke
To wit (for next time): either the second patch should have been folded with the first one, or a bugzilla review should have been requested. Thanks for keeping on updating the MIPS backend, though :)
(In reply to Benjamin Bouvier [:bbouvier] from comment #7)
> To wit (for next time): either the second patch should have been folded with
> the first one, or a bugzilla review should have been requested. Thanks for
> keeping on updating the MIPS backend, though :)

OK. ;)
https://hg.mozilla.org/mozilla-central/rev/3e7561636a36
https://hg.mozilla.org/mozilla-central/rev/415c88053edd
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.