1303688 - Baldr: MIPS: Take advantage of guard page to simplify asm.js/wasm memory access

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[hev [:hev]]

See Bug 1298202

Comment 1

[hev [:hev]]

Attachment: 0001-Bug-1303688-Baldr-MIPS-Take-advantage-of-guard-page-.patch

Comment 2

[hev [:hev]]

Attachment: 0001-Bug-1303688-Baldr-MIPS-Take-advantage-of-guard-page-.patch

Comment 3

[Luke Wagner [:luke]]

Comment on attachment 8792846 [details] [diff] [review]
0001-Bug-1303688-Baldr-MIPS-Take-advantage-of-guard-page-.patch

Review of attachment 8792846 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, and sorry for the churn.

::: js/src/jit/mips-shared/CodeGenerator-mips-shared.cpp
@@ -1779,4 @@
>        default: MOZ_CRASH("unexpected array type");
>      }
>  
> -    memoryBarrier(mir->barrierBefore());

These were removed from the AsmJS* operations because atomics were changed into WasmLoad/Store.  Currently, these two nodes assert there is no barrier, so you'll need to remove those asserts and add the barriers.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e7561636a36
Baldr: MIPS: Take advantage of guard page to simplify asm.js/wasm memory access. r=luke

Comment 5

[hev [:hev]]

Attachment: 0002-Bug-1303688-Baldr-MIPS-Move-memory-barrier-to-WasmLo.patch

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/415c88053edd
Baldr: MIPS: Move memory barrier to WasmLoad/Store. r=luke

Comment 7

[Benjamin Bouvier [:bbouvier] (inactive)]

To wit (for next time): either the second patch should have been folded with the first one, or a bugzilla review should have been requested. Thanks for keeping on updating the MIPS backend, though :)

Comment 8

[hev [:hev]]

(In reply to Benjamin Bouvier [:bbouvier] from comment #7)
> To wit (for next time): either the second patch should have been folded with
> the first one, or a bugzilla review should have been requested. Thanks for
> keeping on updating the MIPS backend, though :)

OK. ;)

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3e7561636a36
https://hg.mozilla.org/mozilla-central/rev/415c88053edd