Closed Bug 1303689 Opened 3 years ago Closed 3 years ago

IonMonkey: MIPS: Implement popcnt32

Categories

(Core :: JavaScript Engine: JIT, defect)

Other
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: hev, Assigned: hev)

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8792760 [details] [diff] [review]
0001-Bug-1303689-IonMonkey-MIPS-Implement-popcnt32.-r-ara.patch

Review of attachment 8792760 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/MacroAssembler.h
@@ +922,3 @@
>  
>      // On x86_shared, temp may be Invalid only if the chip has the POPCNT instruction.
>      // On ARM, temp may never be Invalid.

can you update the comment to mention MIPS?
Attachment #8792760 - Flags: review?(arai.unmht) → review+
Pushed by r@hev.cc:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9502a353f4db
IonMonkey: MIPS: Implement popcnt32. r=arai
https://hg.mozilla.org/mozilla-central/rev/9502a353f4db
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.