Decoder Doctor frontend doesn't record bad formats correctly

RESOLVED FIXED in Firefox 52

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: gerald, Assigned: gerald)

Tracking

49 Branch
mozilla52
All
Windows
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Spawned from bug 1247056 comment 53, fixing a small issue in browser-media.js.

I think that in the worst case, it could delay the recognition that a Decoder Doctor issue has been fixed, which is only used for telemetry purposes.

I'll move the fix in attachment 8792402 [details] here, to get this landed ASAP.

As Gijs suggested, a follow-up bug with tests would be nice!
Comment hidden (mozreview-request)
(Assignee)

Comment 2

a year ago
Gijs, I've moved this patch from bug 1247056, could you please rubber-stamp it?

I agree that tests would be good, but I think we should land this now anyway as it's an obvious fix.
Plus I'm not sure how to test frontend functionality. Would you have pointers for me, or people who could help?

Comment 3

a year ago
mozreview-review
Comment on attachment 8792462 [details]
Bug 1303707 - Fix collecting of formats-at-issues -

https://reviewboard.mozilla.org/r/79512/#review78084
Attachment #8792462 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 4

a year ago
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c71904aaef6a
Fix collecting of formats-at-issues - r=Gijs

Comment 5

a year ago
(In reply to Gerald Squelart [:gerald] from comment #2)
> Gijs, I've moved this patch from bug 1247056, could you please rubber-stamp
> it?
> 
> I agree that tests would be good, but I think we should land this now anyway
> as it's an obvious fix.
> Plus I'm not sure how to test frontend functionality. Would you have
> pointers for me, or people who could help?

You'd probably want a browser mochitest - https://developer.mozilla.org/en-US/docs/Mozilla/Browser_chrome_tests .

This is basically a JS file that executes at chrome window level. For an example that involves notification bars and should be reasonably easy to follow, try e.g. http://searchfox.org/mozilla-central/source/browser/base/content/test/general/browser_popup_blocker.js .

(Rather than using test() with waitForExplicitFinish(), it's usually simpler to just use:

add_task(function*() {
  // write mochitest stuff here.
});

directly.)

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c71904aaef6a
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.