Bad capitalization in SuperSearch facet tabs

RESOLVED WONTFIX

Status

Socorro
Webapp
RESOLVED WONTFIX
2 years ago
7 months ago

People

(Reporter: peterbe, Unassigned, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Created attachment 8792523 [details]
Screen Shot 2016-09-19 at 11.22.12 AM.png

The capitalization of certain fields look weird. For example the "name" might be "cpu_info" but it's displayed as "Cpu info" as if "cpu" is regular word. It ought to be "CPU Info" or "CPU info".
(Reporter)

Comment 1

2 years ago
I'm assuming the labels for the tabs are made something like this: `name.replace('_', ' ').title()`. Can't we just set the Name field in the SuperSearch Fields to "CPU Info"? Or will that mess badly with our select2 drop-downs? And a change like that, what will it mean for people who have saved queries?
If you change the `name` field, you change the API. That is something we should refrain from doing. The field's name is `cpu_info`, and I don't know how we could turn that into `CPU info` in any trivial way. 

I honestly don't think we should care about such a cosmetic thing, but if you really want to change that, I suppose you could simply remove the `| capitalize` rule here: https://github.com/mozilla/socorro/blob/master/webapp-django/crashstats/supersearch/jinja2/supersearch/search_results.html#L79
(Reporter)

Comment 3

2 years ago
We could attack that by having a list of keywords that should be all upper case. Like "CPU", "VM", "OS", etc. We should do the same with the drop-down choices too. So it becomes "Adapter device ID" instead of "adapter device id". 

But if you think this is not important, feel free to close this bug.
I feel this is not important enough for me to work on this, but it looks like a good first bug for someone looking to contribute to Socorro.
Mentor: adrian
I see the problem, but have no interest in fixing this or dealing with maintaining the machinations required to fix this. If I had my druthers, we'd lowercase everything. I'm going to mark this WONTFIX.
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.