Closed Bug 1303793 Opened 8 years ago Closed 8 years ago

Beta mochitest(1) failing with dom/animation/test/mozilla/test_set-easing.html | Setting easing should not throw in sandbox

Categories

(Core :: DOM: Animation, defect)

Product:
Core
Component:
DOM: Animation
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox50 --- fixed
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: hiro)

Details

(Keywords: intermittent-failure)

Attachments

(3 files)

Bug 1303793 - Part 1: Use testharness.js instead of SimpleTest.js to run the test in an iframe easily.
58 bytes, text/x-review-board-request
birtles
: review+
Details
Bug 1303793 - Part 2: Run test which uses the Web Animations API in an iframe with the Web Animations API preference.
58 bytes, text/x-review-board-request
birtles
: review+
Details
[For beta] Part 2: Run test which uses the Web Animations API in an iframe with the Web Animations API preference
3.87 KB, patch
hiro
: review+
Details | Diff | Splinter Review 
Hello Hiro, this test got moved in https://hg.mozilla.org/mozilla-central/rev/e85703fad4a6 as part of bug 1277456. Can you take a look what's the issue, please? bbirtles is busy.
Flags: needinfo?(hiikezoe)
Sure! taking.
Assignee: nobody → hiikezoe
Status: NEW → ASSIGNED
Flags: needinfo?(hiikezoe)
It seems that document.getAnimations can not be seen in the test.  Neither sandbox nor in the original document.   I am not sure what the difference between nightly and beta, but we should be open an iframe window after setting dom.animations-api.core.enabled just like other tests do, and run the test in the iframe window.
(In reply to Sebastian Hengst [:aryx][:archaeopteryx] from comment #4)
> dom.animations-api.core.enabled is set to false on beta and release, see
> http://hg.mozilla.org/releases/mozilla-beta/file/tip/modules/libpref/init/
> all.js#l2659

Thanks! I did not know that beta is 'RELEASE_BUILD'. 

> Does pushing the preference with the value |true| in the test like in
> https://dxr.mozilla.org/mozilla-aurora/source/dom/animation/test/mozilla/
> test_hide_and_show.html#10 fix it?

Yes, it is.  I am just writing it.
Comment on attachment 8792718 [details]
Bug 1303793 - Part 1: Use testharness.js instead of SimpleTest.js to run the test in an iframe easily.

https://reviewboard.mozilla.org/r/79628/#review78270

::: dom/animation/test/mozilla/test_set-easing.html:21
(Diff revision 1)
>    div.animate({ opacity: [0, 1] }, 100000 );
>  
>    const contentScript = function() {
>      try {
>        document.getAnimations()[0].effect.timing.easing = "linear";
> -      ok(true, 'Setting easing should not throw in sandbox');
> +      assert_true(true, 'Setting easing should not throw in sandbox');

I did drop the first argument 'true' locally.
Brian, can you please take time to review both of patches?
Flags: needinfo?(bbirtles)
Severity: normal → blocker
Comment on attachment 8792718 [details]
Bug 1303793 - Part 1: Use testharness.js instead of SimpleTest.js to run the test in an iframe easily.

https://reviewboard.mozilla.org/r/79628/#review78382

Thanks for taking care of this.
Attachment #8792718 - Flags: review+
Oh, (In reply to Brian Birtles (:birtles, busy 19-23 Sep) from comment #12)
> Comment on attachment 8792718 [details]
> Bug 1303793 - Part 1: Use testharnss.js instead of SimpleTest.js to run the
> test in an iframe easily. r?

Nit: s/testharnss.js/testharness.js/ in the commit message.
Flags: needinfo?(bbirtles)
Comment on attachment 8792719 [details]
Bug 1303793 - Part 2: Run test which uses the Web Animations API in an iframe with the Web Animations API preference.

https://reviewboard.mozilla.org/r/79630/#review78384
Attachment #8792719 - Flags: review+
(In reply to Hiroyuki Ikezoe (:hiro) from comment #9)
> Comment on attachment 8792718 [details]
> Bug 1303793 - Part 1: Use testharness.js instead of SimpleTest.js to run the
> test in an iframe easily.
> 
> https://reviewboard.mozilla.org/r/79628/#review78270
> 
> ::: dom/animation/test/mozilla/test_set-easing.html:21
> (Diff revision 1)
> >    div.animate({ opacity: [0, 1] }, 100000 );
> >  
> >    const contentScript = function() {
> >      try {
> >        document.getAnimations()[0].effect.timing.easing = "linear";
> > -      ok(true, 'Setting easing should not throw in sandbox');
> > +      assert_true(true, 'Setting easing should not throw in sandbox');
> 
> I did drop the first argument 'true' locally.

I was somewhat confused about ok().
Pushed by hiikezoe@mozilla-japan.org:
https://hg.mozilla.org/integration/autoland/rev/088fee62d15e
Part 1: Use testharness.js instead of SimpleTest.js to run the test in an iframe easily. r=birtles
https://hg.mozilla.org/integration/autoland/rev/85624e2d619f
Part 2: Run test which uses the Web Animations API in an iframe with the Web Animations API preference. r=birtles
Part 2 (Attachment 8792719 [details]) can not be applied to beta cleanly because of conflict of mochitest.ini.  This is the modified of part 2 for beta branch.
Attachment #8792832 - Flags: review+
(In reply to Hiroyuki Ikezoe (:hiro) from comment #19)
> Created attachment 8792832 [details] [diff] [review]
> [For beta] Part 2: Run test which uses the Web Animations API in an iframe
> with the Web Animations API preference
> 
> Part 2 (Attachment 8792719 [details]) can not be applied to beta cleanly
> because of conflict of mochitest.ini.  This is the modified of part 2 for
> beta branch.

thanks!

landed both on beta

remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/763ecbe1877e
remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/50a24c86a83a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Unless I'm mistaken, this hasn't been merged to m-c yet. Also, it presumably needs to land on Aurora still as well.
Status: RESOLVED → REOPENED
status-firefox51: unaffected → affected
status-firefox52: --- → affected
Resolution: FIXED → ---
Target Milestone: mozilla50 → ---
https://hg.mozilla.org/mozilla-central/rev/088fee62d15e
https://hg.mozilla.org/mozilla-central/rev/85624e2d619f
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: