Closed Bug 1303806 Opened 3 years ago Closed 3 years ago

Move ANRReporter/GeckoJavaSampler/SwipeDismissListViewTouchListener out of geckoview

Categories

(GeckoView :: General, defect)

All
Android
defect
Not set

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(3 files)

Move these Fennec-only classes out of geckoview code and into Fennec. This will also involve some changes in generated JNI bindings.
ANRReporter is a telemetry tool that belongs in Fennec code.

GeckoJavaSampler is a developer tool that belongs in Fennec code.

SwipeDismissListViewTouchListener is only used in FormAssistPopup, which
is no longer referenced in geckoview code.
Attachment #8792601 - Flags: review?(nalexander)
Update #includes to use new headers if necessary. Also remove a couple
of functions in AndroidBridge to clean up the code.
Attachment #8792603 - Flags: review?(snorp)
Comment on attachment 8792601 [details] [diff] [review]
1. Move classes from geckoview to Fennec (v1)

Huh, didn't expect this to be so simple!
Attachment #8792601 - Flags: review?(nalexander) → review+
Comment on attachment 8792603 [details] [diff] [review]
3. Update sources to reflect new bindings (v1)

Review of attachment 8792603 [details] [diff] [review]:
-----------------------------------------------------------------

This is all sensible to me; your call if you want snorp to see this as well.
Attachment #8792603 - Flags: review+
Attachment #8792603 - Flags: review?(snorp) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d79ca15a25b
1. Move classes from geckoview to Fennec; r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/6291e10b1bdb
2. Update auto-generated bindings; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/005bf983f9e3
3. Update sources to reflect new bindings; r=snorp r=nalexander
https://hg.mozilla.org/mozilla-central/rev/6d79ca15a25b
https://hg.mozilla.org/mozilla-central/rev/6291e10b1bdb
https://hg.mozilla.org/mozilla-central/rev/005bf983f9e3
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 52 → mozilla52
You need to log in before you can comment on or make changes to this bug.