If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Move ANRReporter/GeckoJavaSampler/SwipeDismissListViewTouchListener out of geckoview

RESOLVED FIXED in Firefox 52

Status

()

Firefox for Android
GeckoView
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

unspecified
Firefox 52
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

a year ago
Move these Fennec-only classes out of geckoview code and into Fennec. This will also involve some changes in generated JNI bindings.
(Assignee)

Comment 1

a year ago
Created attachment 8792601 [details] [diff] [review]
1. Move classes from geckoview to Fennec (v1)

ANRReporter is a telemetry tool that belongs in Fennec code.

GeckoJavaSampler is a developer tool that belongs in Fennec code.

SwipeDismissListViewTouchListener is only used in FormAssistPopup, which
is no longer referenced in geckoview code.
Attachment #8792601 - Flags: review?(nalexander)
(Assignee)

Comment 2

a year ago
Created attachment 8792602 [details] [diff] [review]
2. Update auto-generated bindings (v1)
Attachment #8792602 - Flags: review+
(Assignee)

Comment 3

a year ago
Created attachment 8792603 [details] [diff] [review]
3. Update sources to reflect new bindings (v1)

Update #includes to use new headers if necessary. Also remove a couple
of functions in AndroidBridge to clean up the code.
Attachment #8792603 - Flags: review?(snorp)
Comment on attachment 8792601 [details] [diff] [review]
1. Move classes from geckoview to Fennec (v1)

Huh, didn't expect this to be so simple!
Attachment #8792601 - Flags: review?(nalexander) → review+
Comment on attachment 8792603 [details] [diff] [review]
3. Update sources to reflect new bindings (v1)

Review of attachment 8792603 [details] [diff] [review]:
-----------------------------------------------------------------

This is all sensible to me; your call if you want snorp to see this as well.
Attachment #8792603 - Flags: review+
Attachment #8792603 - Flags: review?(snorp) → review+

Comment 6

a year ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d79ca15a25b
1. Move classes from geckoview to Fennec; r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/6291e10b1bdb
2. Update auto-generated bindings; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/005bf983f9e3
3. Update sources to reflect new bindings; r=snorp r=nalexander

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6d79ca15a25b
https://hg.mozilla.org/mozilla-central/rev/6291e10b1bdb
https://hg.mozilla.org/mozilla-central/rev/005bf983f9e3
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Depends on: 1305271
You need to log in before you can comment on or make changes to this bug.