1303806 - Move ANRReporter/GeckoJavaSampler/SwipeDismissListViewTouchListener out of geckoview

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Move these Fennec-only classes out of geckoview code and into Fennec. This will also involve some changes in generated JNI bindings.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 1. Move classes from geckoview to Fennec (v1)

ANRReporter is a telemetry tool that belongs in Fennec code.

GeckoJavaSampler is a developer tool that belongs in Fennec code.

SwipeDismissListViewTouchListener is only used in FormAssistPopup, which
is no longer referenced in geckoview code.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 2. Update auto-generated bindings (v1)

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 3. Update sources to reflect new bindings (v1)

Update #includes to use new headers if necessary. Also remove a couple
of functions in AndroidBridge to clean up the code.

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8792601 [details] [diff] [review]
1. Move classes from geckoview to Fennec (v1)

Huh, didn't expect this to be so simple!

Comment 5

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8792603 [details] [diff] [review]
3. Update sources to reflect new bindings (v1)

Review of attachment 8792603 [details] [diff] [review]:
-----------------------------------------------------------------

This is all sensible to me; your call if you want snorp to see this as well.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d79ca15a25b
1. Move classes from geckoview to Fennec; r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/6291e10b1bdb
2. Update auto-generated bindings; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/005bf983f9e3
3. Update sources to reflect new bindings; r=snorp r=nalexander

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6d79ca15a25b
https://hg.mozilla.org/mozilla-central/rev/6291e10b1bdb
https://hg.mozilla.org/mozilla-central/rev/005bf983f9e3