1303828 - Remove transform preventing asan from running on ubuntu16.04

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/transforms/tests/desktop_test.py?q=taskcluster%2Ftaskgraph%2Ftransforms%2Ftests%2Fdesktop_test.py&redirect_type=direct#50
    # Linux64-asan has many leaks with running mochitest-media jobs
    # on Ubuntu 16.04, please remove this when bug 1289209 is resolved

and, indeed, it's resolved!

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

good catch dustin!

I pushed to try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3b2d88decd8a9ee1946d2345a82369a07fdaaa1

we still get leaks (although a different one) :(

I am not sure who could look at this- since this is in /tests/dom/media/mediasource/test, maybe dminor can help me find the right place.


here are the details I see in the log:
[task 2016-09-20T15:52:43.983800Z] 15:52:43     INFO -  =================================================================
[task 2016-09-20T15:52:43.983897Z] 15:52:43     INFO -  ==1050==ERROR: LeakSanitizer: detected memory leaks
[task 2016-09-20T15:52:43.983947Z] 15:52:43     INFO -  Direct leak of 8 byte(s) in 1 object(s) allocated from:
[task 2016-09-20T15:52:43.984015Z] 15:52:43     INFO -      #0 0x4b247b in malloc /builds/slave/moz-toolchain/src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:52:3
[task 2016-09-20T15:52:43.986840Z] 15:52:43     INFO -      #1 0x7fe7f6104778  (<unknown module>)
[task 2016-09-20T15:52:43.987556Z] 15:52:43     INFO -  -----------------------------------------------------
[task 2016-09-20T15:52:43.988439Z] 15:52:43     INFO -  Suppressions used:
[task 2016-09-20T15:52:43.988839Z] 15:52:43     INFO -    count      bytes template
[task 2016-09-20T15:52:43.989258Z] 15:52:43     INFO -      127       1711 libc.so
[task 2016-09-20T15:52:43.990171Z] 15:52:43     INFO -      834      26616 nsComponentManagerImpl
[task 2016-09-20T15:52:43.990977Z] 15:52:43     INFO -       49       7056 mozJSComponentLoader::LoadModule
[task 2016-09-20T15:52:43.992254Z] 15:52:43     INFO -        1        384 pixman_implementation_lookup_composite
[task 2016-09-20T15:52:43.993536Z] 15:52:43     INFO -      178       7125 libfontconfig.so
[task 2016-09-20T15:52:43.995075Z] 15:52:43     INFO -        1         32 libdl.so
[task 2016-09-20T15:52:43.995713Z] 15:52:43     INFO -       17       4348 libglib-2.0.so
[task 2016-09-20T15:52:43.996575Z] 15:52:43     INFO -        2        176 libpulse.so
[task 2016-09-20T15:52:43.997721Z] 15:52:43     INFO -        1         28 libresolv.so
[task 2016-09-20T15:52:43.998499Z] 15:52:43     INFO -  -----------------------------------------------------
[task 2016-09-20T15:52:43.999547Z] 15:52:43     INFO -  SUMMARY: AddressSanitizer: 8 byte(s) leaked in 1 allocation(s).
[task 2016-09-20T15:52:44.245946Z] 15:52:44     INFO -  TEST-INFO | Main app process: exit 0
[task 2016-09-20T15:52:44.247825Z] 15:52:44     INFO -  TEST-INFO | LeakSanitizer | To show the addresses of leaked objects add report_objects=1 to LSAN_OPTIONS
[task 2016-09-20T15:52:44.249173Z] 15:52:44     INFO -  TEST-INFO | LeakSanitizer | This can be done in testing/mozbase/mozrunner/mozrunner/utils.py
[task 2016-09-20T15:52:44.250094Z] 15:52:44  WARNING -  TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at unknown stack

Comment 2

[Dan Minor [:dminor]]

Unfortunately, if you look at the full log, the cubeb leak is still present:

[task 2016-09-20T16:43:49.229985Z] 16:43:49     INFO -  Direct leak of 40 byte(s) in 1 object(s) allocated from:
[task 2016-09-20T16:43:49.230053Z] 16:43:49     INFO -      #0 0x4b2604 in calloc /builds/slave/moz-toolchain/src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:66:3
[task 2016-09-20T16:43:49.230117Z] 16:43:49     INFO -      #1 0x7f6576c4091e in pa_xmalloc0 (/usr/lib/x86_64-linux-gnu/pulseaudio/libpulsecommon-8.0.so+0x1491e)
[task 2016-09-20T16:43:49.230183Z] 16:43:49     INFO -      #2 0x7f658f8a171d in pulse_init /home/worker/workspace/build/src/media/libcubeb/src/cubeb_pulse.c:532:7
[task 2016-09-20T16:43:49.230244Z] 16:43:49     INFO -      #3 0x7f658f89b815 in cubeb_init /home/worker/workspace/build/src/media/libcubeb/src/cubeb.c:152:9
[task 2016-09-20T16:43:49.230308Z] 16:43:49     INFO -      #4 0x7f658bd3288c in GetCubebContextUnlocked /home/worker/workspace/build/src/dom/media/CubebUtils.cpp:201:12
[task 2016-09-20T16:43:49.230378Z] 16:43:49     INFO -      #5 0x7f658bd3288c in mozilla::CubebUtils::InitPreferredSampleRate() /home/worker/workspace/build/src/dom/media/CubebUtils.cpp:137
[task 2016-09-20T16:43:49.230447Z] 16:43:49     INFO -      #6 0x7f658bd3290f in mozilla::CubebUtils::PreferredSampleRate() /home/worker/workspace/build/src/dom/media/CubebUtils.cpp:152:8
[task 2016-09-20T16:43:49.230515Z] 16:43:49     INFO -      #7 0x7f658c29d2d4 in GetSampleRateForAudioContext /home/worker/workspace/build/src/dom/media/webaudio/AudioContext.cpp:93:31
[task 2016-09-20T16:43:49.230623Z] 16:43:49     INFO -      #8 0x7f658c29d2d4 in mozilla::dom::AudioContext::AudioContext(nsPIDOMWindowInner*, bool, mozilla::dom::AudioChannel, unsigned int, unsigned int, float) /home/worker/workspace/build/src/dom/media/webaudio/AudioContext.cpp:105
[task 2016-09-20T16:43:49.230738Z] 16:43:49     INFO -      #9 0x7f658c29e54d in mozilla::dom::AudioContext::Constructor(mozilla::dom::GlobalObject const&, mozilla::dom::AudioChannel, mozilla::ErrorResult&) /home/worker/workspace/build/src/dom/media/webaudio/AudioContext.cpp:185:37
[task 2016-09-20T16:43:49.230838Z] 16:43:49     INFO -      #10 0x7f658c29e417 in mozilla::dom::AudioContext::Constructor(mozilla::dom::GlobalObject const&, mozilla::ErrorResult&) /home/worker/workspace/build/src/dom/media/webaudio/AudioContext.cpp:169:10
[task 2016-09-20T16:43:49.230974Z] 16:43:49     INFO -      #11 0x7f658997ae71 in mozilla::dom::AudioContextBinding::_constructor(JSContext*, unsigned int, JS::Value*) /home/worker/workspace/build/src/obj-firefox/dom/bindings/AudioContextBinding.cpp:2059:62
[task 2016-09-20T16:43:49.231046Z] 16:43:49     INFO -      #12 0x7f6591585c4c in CallJSNative /home/worker/workspace/build/src/js/src/jscntxtinlines.h:235:15
[task 2016-09-20T16:43:49.231118Z] 16:43:49     INFO -      #13 0x7f6591585c4c in CallJSNativeConstructor /home/worker/workspace/build/src/js/src/jscntxtinlines.h:268
[task 2016-09-20T16:43:49.231197Z] 16:43:49     INFO -      #14 0x7f6591585c4c in InternalConstruct(JSContext*, js::AnyConstructArgs const&) /home/worker/workspace/build/src/js/src/vm/Interpreter.cpp:561
[task 2016-09-20T16:43:49.233101Z] 16:43:49     INFO -      #15 0x7f65915643c5 in ConstructFromStack /home/worker/workspace/build/src/js/src/vm/Interpreter.cpp:587:12
[task 2016-09-20T16:43:49.235501Z] 16:43:49     INFO -      #16 0x7f65915643c5 in Interpret(JSContext*, js::RunState&) /home/worker/workspace/build/src/js/src/vm/Interpreter.cpp:2914
[task 2016-09-20T16:43:49.237978Z] 16:43:49     INFO -      #17 0x7f65915499eb in js::RunScript(JSContext*, js::RunState&) /home/worker/workspace/build/src/js/src/vm/Interpreter.cpp:404:12
[task 2016-09-20T16:43:49.239543Z] 16:43:49     INFO -      #18 0x7f6591584ee4 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct) /home/worker/workspace/build/src/js/src/vm/Interpreter.cpp:476:15
[task 2016-09-20T16:43:49.249746Z] 16:43:49     INFO -      #19 0x7f6591585951 in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) /home/worker/workspace/build/src/js/src/vm/Interpreter.cpp:522:10
[task 2016-09-20T16:43:49.250205Z] 16:43:49     INFO -      #20 0x7f6591120638 in js::fun_apply(JSContext*, unsigned int, JS::Value*) /home/worker/workspace/build/src/js/src/jsfun.cpp:1318:12
[task 2016-09-20T16:43:49.250611Z] 16:43:49     INFO -      #21 0x7f65915846cc in CallJSNative /home/worker/workspace/build/src/js/src/jscntxtinlines.h:235:15
[task 2016-09-20T16:43:49.251659Z] 16:43:49     INFO -      #22 0x7f65915846cc in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct) /home/worker/workspace/build/src/js/src/vm/Interpreter.cpp:446
[task 2016-09-20T16:43:49.252377Z] 16:43:49     INFO -      #23 0x7f6591564450 in CallFromStack /home/worker/workspace/build/src/js/src/vm/Interpreter.cpp:509:12
[task 2016-09-20T16:43:49.253406Z] 16:43:49     INFO -      #24 0x7f6591564450 in Interpret(JSContext*, js::RunState&) /home/worker/workspace/build/src/js/src/vm/Interpreter.cpp:2922
[task 2016-09-20T16:43:49.253822Z] 16:43:49     INFO -      #25 0x7f65915499eb in js::RunScript(JSContext*, js::RunState&) /home/worker/workspace/build/src/js/src/vm/Interpreter.cpp:404:12
[task 2016-09-20T16:43:49.256150Z] 16:43:49     INFO -      #26 0x7f6591584ee4 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct) /home/worker/workspace/build/src/js/src/vm/Interpreter.cpp:476:15
[task 2016-09-20T16:43:49.256658Z] 16:43:49     INFO -      #27 0x7f6591585951 in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) /home/worker/workspace/build/src/js/src/vm/Interpreter.cpp:522:10
[task 2016-09-20T16:43:49.257189Z] 16:43:49     INFO -      #28 0x7f65910825d8 in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) /home/worker/workspace/build/src/js/src/jsapi.cpp:2836:12
[task 2016-09-20T16:43:49.257695Z] 16:43:49     INFO -      #29 0x7f658af96578 in mozilla::dom::EventHandlerNonNull::Call(JSContext*, JS::Handle<JS::Value>, mozilla::dom::Event&, JS::MutableHandle<JS::Value>, mozilla::ErrorResult&) /home/worker/workspace/build/src/obj-firefox/dom/bindings/EventHandlerBinding.cpp:259:37
[task 2016-09-20T16:43:49.262128Z] 16:43:49     INFO -      #30 0x7f658b8b2ff1 in Call<nsISupports *> /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/EventHandlerBinding.h:361:12
[task 2016-09-20T16:43:49.262585Z] 16:43:49     INFO -      #31 0x7f658b8b2ff1 in mozilla::JSEventHandler::HandleEvent(nsIDOMEvent*) /home/worker/workspace/build/src/dom/events/JSEventHandler.cpp:214
[task 2016-09-20T16:43:49.263015Z] 16:43:49     INFO -      #32 0x7f658b87f774 in mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, nsIDOMEvent*, mozilla::dom::EventTarget*) /home/worker/workspace/build/src/dom/events/EventListenerManager.cpp:1133:16
[task 2016-09-20T16:43:49.263438Z] 16:43:49     INFO -      #33 0x7f658b8812a1 in mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, nsIDOMEvent**, mozilla::dom::EventTarget*, nsEventStatus*) /home/worker/workspace/build/src/dom/events/EventListenerManager.cpp:1286:17
[task 2016-09-20T16:43:49.263885Z] 16:43:49     INFO -      #34 0x7f658b86a592 in mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&) /home/worker/workspace/build/src/dom/events/EventDispatcher.cpp:380:5
[task 2016-09-20T16:43:49.264323Z] 16:43:49     INFO -      #35 0x7f658b86ea7d in mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, nsIDOMEvent*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*) /home/worker/workspace/build/src/dom/events/EventDispatcher.cpp:711:9
[task 2016-09-20T16:43:49.264745Z] 16:43:49     INFO -      #36 0x7f658dab5928 in nsDocumentViewer::LoadComplete(nsresult) /home/worker/workspace/build/src/layout/base/nsDocumentViewer.cpp:998:7
[task 2016-09-20T16:43:49.265127Z] 16:43:49     INFO -      #37 0x7f658e834e9e in nsDocShell::EndPageLoad(nsIWebProgress*, nsIChannel*, nsresult) /home/worker/workspace/build/src/docshell/base/nsDocShell.cpp:7615:5

I filed Bug 1293658 a while back to track getting that fixed.

"leak at unknown stack" is pretty much as unactionable as it gets... Since I have an Ubuntu 16.04 system, I'm going to try a local ASAN build to see if any of these leaks reproduces.

Comment 3

[Dan Minor [:dminor]]

Joel, it looks like the media leaks are now fixed:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=97e5846bab0c8b06cbcd110f695adf52fd90bc2a

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

dminor, can you just push that patch up for review?  what you did looks correct.

Comment 5

[Dan Minor [:dminor]]

It looks like there is now a failure in browser/components/search/test/browser_aboutSearchReset.js

see:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=73a4fdb54a4a13a128ca1daecc7d641f3d9a03de

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Is there anything left to do here?

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

we are 100% on linux64, no need for asan transforms!