1303860 - desktop-test image contains 1+ GB of mesa package files

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Gregory Szorc [:gps]]

ubuntu1204-test-system-setup.sh downloads a 590,643,702 byte mesa-repo-9.2.1-1ubuntu3~precise1mozilla2.tgz file containing tons of .deb files. Both this file and the extracted .deb files are part of the final Docker image, bloating the image size by over 1 GB.

This wasted space can contribute significant overhead to job execution, as that is 1 GB that needs to be transferred to workers and loaded into Docker.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1303860 - Don't change directory when installing Mercurial;

install-mercurial.sh was switching directories to /usr/local/mercurial
resulting in following actions adding files to that path. We don't
want that. So use pushd/popd to preserve cwd.

A side effect of this change is that subsequent operations save files
in a path that is blown away at the end of setup. This reduces the
desktop-test Docker image size by ~1.2 GB.

Review commit: https://reviewboard.mozilla.org/r/79580/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79580/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8792660 [details]
Bug 1303860 - Don't change directory when installing Mercurial;

https://reviewboard.mozilla.org/r/79580/#review78244

From a look around, the issue is that install-mercurial.sh changes the cwd (to /usr/local/mercurial) and doesn't change it back.  So all that stuff got downloaded to /usr/local/mercurial and the cleanup of /setup at the end didn't delete it.

The pushd/popd fix here doesn't seem right, not least because the pushd is for the same directory the scripts `cd` to a few dozen lines earlier.  I'd prefer to see install-mercurial be a bit better behaved, perhaps by using pushd/popd when it runs the tooltool fetch, or even just fetching robustcheckout.py locally and moving it to /usr/local/mercurial.

At any rate, r+ since this will fix a serious issue.. just not quite the way I'd like!

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8792660 [details]
Bug 1303860 - Don't change directory when installing Mercurial;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79580/diff/1-2/

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8792660 [details]
Bug 1303860 - Don't change directory when installing Mercurial;

https://reviewboard.mozilla.org/r/79580/#review78246

Much better!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efe0f5cfb537
Don't change directory when installing Mercurial; r=dustin

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/efe0f5cfb537