13039 - Button positioning in dialogs incorrect

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P1)

Description

[cpratt]

Build ID: 1999090208
Platform: all (checked Mac OS and Windows; Unix busted)

To reproduce:
- Launch apprunner
- Open the Preferences (for example; you can also check this in the Profile
Manager)
- Look at the positioning of the buttons

Result: The buttons are in the lower left hand corner of the dialog.

Expected result: They should be in the lower right hand corner of the dialog.

I would expect this to be a major usability problem as people are used to
mousing down to the lower right hand corner of a dialog to OK or dismiss it.

Comment 1

[davidm]

reassign to matt. This dialog should probably be using the dialogOverlay.xul so
that when button reordering is implement, the dialog does the right thing.

Comment 2

[don]

Good call by Daivd.

Yeah, this drives me crazy ...

Comment 3

[don]

Let's argue about where the damn button are gonna be later.  Move to M14.

Comment 4

[don]

Ben, can you handle this after beta?

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

buttons are now in the center of the dialog, which is wrong on all platforms (I
think.. at least 4.x mac and Win have the buttons positioned at right). I've
made these changes in my prefs stuff and will check in fix when I land new prefs
code.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

fix checked in with new prefwindow. looks ok on windows. no help button, but of
course we have no help ;)

Comment 7

[Eli Goldberg]

Looks fixed on late-January M14 builds on Mac OS/Win32/Linux. Rubber-stamping as 
verified fixed.

Comment 8

[Eli Goldberg]

[doh]

Comment 9

[leger]

Bulk move of all Pref UI component bugs to new Preferences component.  Pref UI 
component will be deleted.