1303930 - can't play https://www.youtube.com/embed/1visYpIREUM?autoplay=1, sometimes crash

Status: RESOLVED WORKSFORME

(Core :: Graphics: Layers, defect, P3)

Description

[Farmer Tseng[:fatseng](inactive)]

Attachment: screen shot

Can't play https://www.youtube.com/embed/1visYpIREUM?autoplay=1
Sometimes appear green image(see attachment), sometimes crash.
It can't be reproduced in Beta, but always happen in my Windows 7 with nightly.
My equipment:
Lenovo NB
Intel(R)Core(TM) i7-3520M CPU@2.90GHz
RAM: 8 GB
OS: Windows7-64bits
Graphic driver:Intel(R) HD Graphics 4000 version:9.17.10.2843

Comment 1

[Farmer Tseng[:fatseng](inactive)]

Here is crash call stack.
 	xul.dll!mozilla::layers::IMFYCbCrImage::GetTextureClient(mozilla::layers::CompositableClient * aClient) 第 253 行	C++
 	xul.dll!mozilla::layers::ImageClientSingle::UpdateImage(mozilla::layers::ImageContainer * aContainer, unsigned int aContentFlags) 第 171 行	C++
>	xul.dll!mozilla::layers::ImageBridgeChild::UpdateImageClient(RefPtr<mozilla::layers::ImageClient> aClient, RefPtr<mozilla::layers::ImageContainer> aContainer) 第 674 行	C++
 	xul.dll!mozilla::detail::RunnableMethodCallHelper<void>::apply<RefPtr<mozilla::layers::ImageBridgeChild>,void (__thiscall mozilla::layers::ImageBridgeChild::*)(RefPtr<mozilla::layers::ImageClient>,RefPtr<mozilla::layers::ImageContainer>),RefPtr<mozilla::layers::ImageClient>,RefPtr<mozilla::layers::ImageContainer>,0,1>(RefPtr<mozilla::layers::ImageBridgeChild> obj, void(mozilla::layers::ImageBridgeChild::*)(RefPtr<mozilla::layers::ImageClient>, RefPtr<mozilla::layers::ImageContainer>) method, mozilla::Tuple<RefPtr<mozilla::layers::ImageClient>,RefPtr<mozilla::layers::ImageContainer> > & args, mozilla::IndexSequence<0,1> __formal) 第 103 行	C++
 	xul.dll!mozilla::runnable_args_memfn<RefPtr<mozilla::layers::ImageBridgeChild>,void (__thiscall mozilla::layers::ImageBridgeChild::*)(RefPtr<mozilla::layers::ImageClient>,RefPtr<mozilla::layers::ImageContainer>),RefPtr<mozilla::layers::ImageClient>,RefPtr<mozilla::layers::ImageContainer> >::Run() 第 169 行	C++
 	xul.dll!MessageLoop::RunTask(already_AddRefed<mozilla::Runnable> aTask) 第 347 行	C++
 	xul.dll!MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask && pending_task) 第 357 行	C++
 	xul.dll!MessageLoop::DoWork() 第 429 行	C++
 	xul.dll!base::MessagePumpDefault::Run(base::MessagePump::Delegate * delegate) 第 36 行	C++
 	xul.dll!MessageLoop::RunInternal() 第 233 行	C++
 	xul.dll!MessageLoop::RunHandler() 第 226 行	C++
 	xul.dll!MessageLoop::Run() 第 206 行	C++
 	xul.dll!base::Thread::ThreadMain() 第 183 行	C++
 	xul.dll!`anonymous namespace'::ThreadFunc(void * closure) 第 29 行	C++

Comment 2

[Farmer Tseng[:fatseng](inactive)]

It crashed while calling CreateTexture2D.
 HRESULT hr = device->CreateTexture2D(&newDesc, &yData, getter_AddRefs(textureY));

Comment 3

[Blake Wu [:bwu][:blakewu]]

(In reply to Farmer Tseng[:fatseng] from comment #2)
> It crashed while calling CreateTexture2D.
>  HRESULT hr = device->CreateTexture2D(&newDesc, &yData,
> getter_AddRefs(textureY));
I don't see it in comment 1.

Comment 4

[Farmer Tseng[:fatseng](inactive)]

2016-08-09-central nightly build is good.(changeset 308558 	720b5d2c84d5)
2016-08-10-central nightly build is fail.(changeset 308748 	6cf0089510fa)

Comment 5

[Farmer Tseng[:fatseng](inactive)]

(In reply to Blake Wu [:bwu][:blakewu] from comment #3)
> (In reply to Farmer Tseng[:fatseng] from comment #2)
> > It crashed while calling CreateTexture2D.
> >  HRESULT hr = device->CreateTexture2D(&newDesc, &yData,
> > getter_AddRefs(textureY));
> I don't see it in comment 1.

It is in IMFYCbCrImage::GetTextureClient
http://searchfox.org/mozilla-central/source/gfx/layers/IMFYCbCrImage.cpp#253

Comment 6

[Blake Wu [:bwu][:blakewu]]

Got it. Thanks!
We should change the component to GFX.

Comment 7

[Farmer Tseng[:fatseng](inactive)]

I found this patch cause regression.

changeset:   308741:f22049a0aa1f
user:        Matt Woodrow <[e-mail]>
date:        Tue Aug 09 15:55:06 2016 +1200
summary:     Bug 1292498 - Don't support D3D11 feature level 9_3 since it doesn't work with any of our use cases. r=Bas

Comment 8

[Gregory Pappas [:gregp]]

Unable to reproduce