1304003 - New console frontend: Rewrite e2e tests for new console

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P2)

Description

[Lin Clark [:linclark]]

See https://github.com/devtools-html/gecko-dev/issues/292

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/1e5f9d90fc09
Part 1: Rewrite browser_bug_865871_variables_view_close_on_esc_key.js. r=bgrins
https://hg.mozilla.org/integration/fx-team/rev/a8e9cad6a93a
Part 2: Rewrite browser_webconsole_bug_579412_input_focus.js. r=bgrins
https://hg.mozilla.org/integration/fx-team/rev/69a451ac9460
Part 3: Rewrite browser_webconsole_notifications.js. r=bgrins

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1e5f9d90fc09
https://hg.mozilla.org/mozilla-central/rev/a8e9cad6a93a
https://hg.mozilla.org/mozilla-central/rev/69a451ac9460

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/26db1201179f
Rewrite browser_console_click_focus.js. r=bgrins

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/26db1201179f

Comment 6

[Patrick Brosset <:pbro>]

As per the DevTools triage process doc [1], a P1 is defined as:
- a security hole
- causing data-loss
- causing a crash
- stopping the tools working
- embarrassing
Should be fixed within 24h and your manager should know about it and, between you, assign it to someone who can fix it.

This bug has been set to P1 a month ago and is still unassigned.

Lin: does it need to stay leave-open? Should it be a P1? Should someone be working on this now?

[1] https://docs.google.com/document/d/1uG0foc0pphXJB489_8ClKjYr1wbRXeFyrkd_kIOv9ao/edit#

Comment 7

[Lin Clark [:linclark]]

Yes, it should stay leave-open, but no it does not need to be P1.

If we have extra hands to work on the console, then yes, it would be great to have someone helping out with this. I can explain to them what needs to happen on this if so. Otherwise, this is a priority after I finish perf stuff and the test issues that we talked about with stubs.

Comment 8

[Patrick Brosset <:pbro>]

(In reply to Lin Clark [:linclark] from comment #7)
> Yes, it should stay leave-open, but no it does not need to be P1.
> 
> If we have extra hands to work on the console, then yes, it would be great
> to have someone helping out with this. I can explain to them what needs to
> happen on this if so. Otherwise, this is a priority after I finish perf
> stuff and the test issues that we talked about with stubs.
Thanks Lin for the clarification.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:nchevobbe, maybe it's time to close this bug?

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

I agree, and we did a big work of rewriting all the relevant tests from the old to the new frontend.