Closed
Bug 1304017
Opened 8 years ago
Closed 8 years ago
improve MultipartBlobImpl refcounting
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
8.30 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
MultipartBlobImpl always requires copying the incoming BlobImpl array. This copying, and its associated refcounting, is unnecessary in many cases, as we're just going to delete the copied-from array anyway. We might as well pass in ownership when creating the multipart blob and avoid all the overhead associated with copying and refcounting.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8792884 -
Flags: review?(amarchesini)
|
||
Updated•8 years ago
|
Attachment #8792884 -
Flags: review?(amarchesini) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/665d28dc815d improve MultipartBlobImpl refcounting; r=baku
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/665d28dc815d
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•