130403 - No default Address Book set to "Add to:" in New card from "Select Addresses" dlg

Status: VERIFIED FIXED

(MailNews Core :: LDAP Integration, defect)

Description

[yulian chang]

20020312 trunk build on Win2K.


In "Select Addresses" dlg, clicking "New..." button to open New Card dlg, no
default Personal Address Book is set to "Add to:". The New Card dlg launching from
Address Book window has Personal Address Book set to "Add to:". Better to have
default Personal Address Book for user to add to.

Comment 1

[Peter Bartecki]

The same situation can be observed with Build ID 2002052006 on Win98. But I
didn't have those problems with Linux Mozilla 1.0 RC2 Build - Personal
AddressBook is selected as default (when New Card is launched from "Select
Addresses" window.)

Comment 2

[Ninoschka Baca]

Branch and Trunk builds on 2002-05-22: WinMe
With only a Personal Address Book and Collected Address Book present this
appears to be working for me. Yulian, is this a general problem or specific to LDAP?

Comment 3

[yulian chang]

20020523 Branch build on Win2K

Ran into the same problem.
1. New Compose window
2. Click on Addresses Toolbar
3. Select Addresses dlg appears
4. Click on New button on the left bottom
5. New Card dlg appears 
6. Personal Address Book or Collected Address Book doesn't present for "Add To:"
in  the dropdown box

Comment 4

[Peter Bartecki]

It looks like as we got some regression here.
I can now repeat this bug on Linux too - with Mozilla 1.1 (2002061108) when
1.0RC2 on Linux was working OK.

Comment 5

[Srilatha Moturi]

Taking this after talking to Shuehan

Comment 6

[Srilatha Moturi]

nominating since its a regression

Comment 7

[Srilatha Moturi]

This is happening because of the following js error
JavaScript error:
 line 0: uncaught exception: [Exception... "Component returned failure code: 
0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface]"  nsresult: "0x80004002 
(NS_NOINTERFACE)"  location: "JS frame :: 
chrome://messenger/content/addressbook/abCommon.js :: GetDirectoryFromURI :: 
line 882"  data: no]

Comment 8

[Srilatha Moturi]

Attachment: proposed patch

We are getting the js error because there is no selected addressbook. The fix
is to make personal addressbook as selected addressbook when we do not have a
selected addressbook.

Comment 9

[David :Bienvenu]

Comment on attachment 88493 [details] [diff] [review]
proposed patch

sr=bienvenu

Comment 10

[varada]

Comment on attachment 88493 [details] [diff] [review]
proposed patch

r=varada

Comment 11

[Scott MacGregor]

plussing the nsbeta1 nomination so this can get on the adt radar. If we can get
this checked into the trunk today and verified in tomorrows bits we can try to
get this into the branch tomorrow. 

Comment 12

[Srilatha Moturi]

Fix checked into the trunk

Comment 13

[Jaime Rodriguez, Jr.]

adt1.0.1+ (on adt's behalf) approval for checkin to the 1.0 branch, pending
drivers approval. pls checkin this in asap, the add the "fixed1.0.1" keyword.

Comment 14

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 15

[yulian chang]

Verified with 20020621 trunk build on Win2K.

Comment 16

[Srilatha Moturi]

Fix checked into the branch

Comment 17

[yulian chang]

Verified with branch builds on various platforms.