130404 - should accel+shift+K toggle caret mode when focus is in a dialog?

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[sairuh (rarely reading bugmail)]

saw this using 2002.03.12 comm bits on all platforms. not sure if this is
expected behavior, but i noticed that if i have a dialog up(*) and focus is in
it (i also make sure the pointer is over it too, to make it simple), that the
shortcut for toggling caret browsing mode is recognized (accel+shift+K).

(*)see this both modal and non-modal dlgs, like Find and Open Web Location,
respectively. also occurs with the Prefs window.

to repro:

1. make sure caret browsing mode is on.
2. bring up either a modal or non-modal dialog, or some window like Prefs.
3. make sure both focus is in that dlg/window; make sure your mouse pointer is
over it, too.
4. hit accel+shift+K.
5. dismiss the dlg/window, and return to the browser window.

results: caret browsing is now off.

expected: shouldn't this shortcut be disabled unless we're in a window with
content? (ie, browser window, message pane of mail 3pane, mail standalone)

side note: fortunately, this is not a problem with windows such as the editor or
mail compose --where accel+shift+K continues to work as "discontinue link".

Comment 1

[Aaron Leventhal]

I spoke with Simon about a better way to support the Accel+Shift+K keyboard
shortcut, via the chrome, rather that through nsGlobalWindow.cpp. That will fix
this.`

Comment 2

[Aaron Leventhal]

This was fixed due to my checkin for bug 128025

Comment 3

[sairuh (rarely reading bugmail)]

rs vrfy.

side note: caret mode doesn't appear to be implemented in embedded apps, at
least in chimera. for the case of chimera, if/when caret mode is implemented,
then we could revisit cmd-chift-K as a possibility...