Test webdriver-spec tests on treeherder

RESOLVED FIXED in Firefox 52

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jgraham, Unassigned)

Tracking

(Blocks 1 bug)

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(5 attachments)

Plan:

* Upload geckodriver to tooltool
* Change the mozharness job for webdriver-spec to download geckodriver
* Add the mozharness job to taskcluster (/ buildbot?) configs
Comment hidden (mozreview-request)

Comment 6

3 years ago
mozreview-review
Comment on attachment 8795687 [details]
Bug 1304046 - Pass absolute test path in to pytest,

https://reviewboard.mozilla.org/r/81662/#review80270

::: testing/web-platform/harness/wptrunner/wpttest.py:131
(Diff revision 1)
>          return self.id == other.id
>  
>      @classmethod
>      def from_manifest(cls, manifest_item, inherit_metadata, test_metadata):
>          timeout = LONG_TIMEOUT if manifest_item.timeout == "long" else DEFAULT_TIMEOUT
> -        return cls(manifest_item.url,
> +        protocol="https" if hasattr(manifest_item, "https") and manifest_item.https else "http"

More spaces around `=`

::: testing/web-platform/harness/wptrunner/wpttest.py:336
(Diff revision 1)
> +    @property
> +    def abs_path(self):
> +        return os.path.join(self.tests_root, self.path)

Is this necessary? This exists on the superclass.

Comment 7

3 years ago
mozreview-review
Comment on attachment 8795687 [details]
Bug 1304046 - Pass absolute test path in to pytest,

https://reviewboard.mozilla.org/r/81662/#review80272
Attachment #8795687 - Flags: review?(Ms2ger) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 13

3 years ago
mozreview-review
Comment on attachment 8795688 [details]
Bug 1304046 - Update expected data for WebDriver tests,

https://reviewboard.mozilla.org/r/81664/#review80360
Attachment #8795688 - Flags: review?(ato) → review+

Comment 14

3 years ago
mozreview-review
Comment on attachment 8795686 [details]
Bug 1304046 - Update geckodriver command line arguments for v0.11,

https://reviewboard.mozilla.org/r/81660/#review80358
Attachment #8795686 - Flags: review?(ato) → review+

Comment 15

3 years ago
mozreview-review
Comment on attachment 8795685 [details]
Bug 1304046 - Add taskcluster task for running wdspec tests,

https://reviewboard.mozilla.org/r/81658/#review80450
Attachment #8795685 - Flags: review?(dustin) → review+

Comment 16

3 years ago
mozreview-review
Comment on attachment 8795684 [details]
Bug 1304046 - Add wdspec support to mozharness,

https://reviewboard.mozilla.org/r/81656/#review80616

Lgtm.

::: testing/mozharness/scripts/web_platform_tests.py:222
(Diff revision 2)
> +        compressed_path = os.path.join(dirs['abs_work_dir'], geckodriver_filename)
> +        tar = self.query_exe('tar', return_type="list")
> +        self.run_command(tar + ["xf", compressed_path], cwd=dirs['abs_work_dir'],
> +                         halt_on_failure=True, fatal_exit_code=3)
> +        self.geckodriver_path = os.path.join(dirs['abs_work_dir'], "geckodriver")

This could use mozfile.extract() instead, then you wouldn't need to assert tar.gz. I guess the current way is fine too.
Attachment #8795684 - Flags: review?(ahalberstadt) → review+
Reporter

Comment 17

3 years ago
mozreview-review-reply
Comment on attachment 8795684 [details]
Bug 1304046 - Add wdspec support to mozharness,

https://reviewboard.mozilla.org/r/81656/#review80616

> This could use mozfile.extract() instead, then you wouldn't need to assert tar.gz. I guess the current way is fine too.

I'll fix this in a folowup.

Comment 18

3 years ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/0aae35666a87
Add wdspec support to mozharness, r=ahal
https://hg.mozilla.org/integration/autoland/rev/66d217ff1f01
Add taskcluster task for running wdspec tests, r=dustin
https://hg.mozilla.org/integration/autoland/rev/9fd9536c6fbb
Update geckodriver command line arguments for v0.11, r=ato
https://hg.mozilla.org/integration/autoland/rev/f07b305e3d11
Pass absolute test path in to pytest, r=Ms2ger
https://hg.mozilla.org/integration/autoland/rev/215adbcb1987
Update expected data for WebDriver tests, r=ato
You need to log in before you can comment on or make changes to this bug.