1304102 - No events shown in Multiweek view [TypeError: dayStart.clone is not a function]

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Upgraded to Thunderbird 51.0a2 (20160920004004) with Lightning 5.3a2 today. 

Events are shown in today pane but the calendar tab view remains empty and all buttons in the calendar tab toolbar are disabled.

Error console shows:

> TypeError: dayStart.clone is not a function[Learn More]  calendar-views.xml:191:28
> 	goToDay chrome://calendar/content/calendar-views.xml:191:28
> 	switchToView chrome://calendar/content/calendar-views.js:258:5
> 	switchCalendarView chrome://lightning/content/messenger-overlay-sidebar.js:591:5
> 	commonInitCalendar chrome://calendar/content/calendar-chrome-startup.js:22:5
> 	ltnOnLoad chrome://lightning/content/messenger-overlay-sidebar.js:373:5

> TypeError: dayStart.clone is not a function[Learn More] calendar-views.xml:191:28
> 	goToDay chrome://calendar/content/calendar-views.xml:191:28
> 	switchToView chrome://calendar/content/calendar-views.js:258:5
> 	ltnSwitch2Calendar chrome://lightning/content/messenger-overlay-sidebar.js:745:9
> 	calendarTabType.modes.calendar.showTab chrome://lightning/content/messenger-overlay-sidebar.js:60:17
> 	updateCurrentTab chrome://messenger/content/tabmail.xml:1157:15
> 	onxblselect chrome://messenger/content/tabmail.xml:2064:11
> 	set_selectedIndex chrome://global/content/bindings/tabbox.xml:406:15
> 	set_selectedItem chrome://global/content/bindings/tabbox.xml:431:34
> 	_selectNewTab chrome://global/content/bindings/tabbox.xml:476:11
> 	onxblmousedown chrome://global/content/bindings/tabbox.xml:782:11

Comment 1

[Stefan Sitter [:ssitter]]

When using a new profile the error is only reported in multiweek view but it is possible to switch to another view. In my existing profile it is not possible to switch to another view.

Comment 2

[Stefan Sitter [:ssitter]]

Regression from Bug 1280898

> let d1 = getWeekInfoService().getStartOfWeek(aDate);
> d1.day -= (7 * Preferences.get("calendar.previousweeks.inview", 0));

was changed to 

> let dayStart = cal.getWeekInfoService().getStartOfWeek(aDate);
> dayStart -= 7 * Preferences.get("calendar.previousweeks.inview", 0);

but should be dayStart.day -= ... Same for d2.day +=... vs. dayEnd +=...

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Since this is basically your patch I'm going take this as a review. I've tested and it works as expected.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

https://hg.mozilla.org/comm-central/rev/255f1b27939e

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8793027 [details]
Fix - v1

a+ for aurora, I guess it wasn't the best idea to do eslint checkins right before the merge :)

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

aurora is closed for merge failures, will have to postpone aurora checkin.

Comment 7

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/comm-aurora/rev/158ba2f89342

Merge failures, which merge failures? C-A will look pretty green with this push, I reckon ;-)

Comment 8

[[:MakeMyDay]]

Resolving this fixed, however there still seems to be at least one other issue. On today's Daily, in multiweeks view only recurring events are displayed, no single events and unfortunately no messages in the console - maybe already reported in bug 1304251, so let's track that there.

Comment 9

[[:MakeMyDay]]

Please ignore the last comment, I've found my events.