1304206 - Offline browsing: flip switchboard flag in Kinto to enable it in 50+ releases

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[:Grisha Kruglov]

In 50 we switched from using experiments.json file to synchronizing config from Kinto. Bug 1303844 flipped the switch in experiments.json for 49 release, but now we need to do the same on the Kinto side.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Should we already update the configuration or are there bugs that need to be fixed before we actually want to enable it for 50+ release versions? If there are some bugs then we could make them block this one.

Comment 2

[:Grisha Kruglov]

(In reply to Sebastian Kaspari (:sebastian) from comment #1)
> Should we already update the configuration or are there bugs that need to be
> fixed before we actually want to enable it for 50+ release versions? If
> there are some bugs then we could make them block this one.

I just filed another UI bug, which I think is minor but worth fixing. I'm going to reach out to SV to get a more thorough look-over for 50+. 50 isn't released for another month or so, which gives us time to wait before flipping this switch.

I do want to have this enabled on any non-release version, but the conclusion of Bug 1301904 was that this might not be the case for Aurora (indicating that something might be going on with our switchboard config?). I'll see what's going on there.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Are there still tasks to be done before we can enable this in the next release?

Comment 4

[:Grisha Kruglov]

I've just filed Bug 1323279, but that's the only "new" issue I've noticed in some time.

Generally, I need to write up a good test plan and get softvision folks to help us out getting this stuff properly verified. Then we can pick a target release to aim for (ideally 51, but if there's any more work to do, then 52).

Sebastian, who do you think I should refer to at the s.v. side to get help with this?

Comment 5

[:Grisha Kruglov]

In regards to releases, if there are no new patches, I suppose we could also just enable this feature at any point in time and not tie it to a release schedule.

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to :Grisha Kruglov from comment #4)
> Sebastian, who do you think I should refer to at the s.v. side to get help
> with this?

I'd start with Ioana (NI). :)

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Oh, and feel free to move as much as possible of this to the new core browser team. Barbara can prioritize this and integrate it into the roadmap.

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

Barbara: This feature could be enabled again - but needs some testing / verification.

Comment 9

[Barbara Bermes [:barbara] - NI please!]

Yes, let's do it, I see Ioana NI'd so we'll get this on Softvisions radar.

Comment 10

[Jan Henning [:JanH]]

Any news what's still keeping this in limbo now that another half year has passed?

Comment 11

[:Grisha Kruglov]

(In reply to Jan Henning [:JanH] from comment #10)
> Any news what's still keeping this in limbo now that another half year has
> passed?

Thanks for bringing this up! I was thinking of this just recently. I think the main problem is that "no one was keeping up with this", myself included, and it slipped through the cracks. Which is a shame for a very useful feature.

I think I would be comfortable switching this ON for a release. IIRC, we flushed out the bugs a while back. Bug 1323279 is annoying, but tolerable and limited in scope, and should be an easy-enough fix. I also have a feeling that bug is likely to be limited to certain subset of devices. Waiting for that fix to ride the trains means waiting another three (or is it two now?) cycles, which is silly.

My vote is to enable it. This _has_ been enabled for non-release builds, and we haven't any bugs come in. It's a great little feature, and I rely on it often. Generally, the net benefit outweighs the risk.

CC'ing Joe for product visibility.

Comment 12

[:Grisha Kruglov]

Flag was flipped last week, enabling "offline browsing" for the entire population.