Closed
Bug 1304209
Opened 8 years ago
Closed 8 years ago
Remove Debugger.Script.prototype.canonicalId
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
Details
Attachments
(1 file)
|
6.15 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
The `canonicalId` getter is never actually used, and isn't implemented in the most principled way. Therefore, let's get rid of it, before it turns into technical debt.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8793094 -
Flags: review?(shu)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8fb127f58d8
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8793094 [details] [diff] [review] Remove Debugger.Script.prototype.canonicalId Review of attachment 8793094 [details] [diff] [review]: ----------------------------------------------------------------- Oh you remembered to update the docs too, wonderful.
Attachment #8793094 -
Flags: review?(shu) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/fx-team/rev/bf78a4c31c1c Remove Debugger.Script.prototype.canonicalId. r=shu
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bf78a4c31c1c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•