Closed
Bug 1304341
Opened 7 years ago
Closed
Icons in the main menu, identity block and control center need more opacity in high-contrast mode and on Linux
Categories
(Firefox :: Theme, defect, P2)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 52
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Keywords: access)
Attachments
(1 file, 1 obsolete file)
101.29 KB,
patch
|
gchang
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The transparency currently used on these icons is too high to satisfy accessibility requirements.
Attachment #8793264 -
Flags: review?(jhofmann)
Comment 1•7 years ago
|
||
Comment on attachment 8793264 [details] [diff] [review] patch Review of attachment 8793264 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! ::: browser/themes/shared/jar.inc.mn @@ +71,2 @@ > skin/classic/browser/notification-icons.svg (../shared/notification-icons.svg) > +* skin/classic/browser/tracking-protection-16.svg (../shared/identity-block/tracking-protection-16.svg) It looks like the changes in this file are only reordering, right?
Attachment #8793264 -
Flags: review?(jhofmann) → review+
Assignee | ||
Comment 2•7 years ago
|
||
(In reply to Johann Hofmann [:johannh] from comment #1) > Comment on attachment 8793264 [details] [diff] [review] > patch > > Review of attachment 8793264 [details] [diff] [review]: > ----------------------------------------------------------------- > > Looks good! > > ::: browser/themes/shared/jar.inc.mn > @@ +71,2 @@ > > skin/classic/browser/notification-icons.svg (../shared/notification-icons.svg) > > +* skin/classic/browser/tracking-protection-16.svg (../shared/identity-block/tracking-protection-16.svg) > > It looks like the changes in this file are only reordering, right? No, I've added * which enables preprocessing for these files.
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7d6f520753a2 Increase opacity of icons in the main menu, identity block and control center in high-contrast mode and on Linux. r=jhofmann
Comment 4•7 years ago
|
||
backed out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=36282655&repo=mozilla-inbound
Flags: needinfo?(dao+bmo)
Backout by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/efcbe1b8f73a Backed out changeset 7d6f520753a2 for bustage on a CLOSED TREE
Assignee | ||
Comment 6•7 years ago
|
||
Looks like I need to remove Windows line endings from some SVG files. I don't understand why this was building locally on Linux, though.
Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ef2896b755b7 Increase opacity of icons in the main menu, identity block and control center in high-contrast mode and on Linux. r=jhofmann
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ef2896b755b7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ef2896b755b7
Closed: 7 years ago → 7 years ago
Comment 10•7 years ago
|
||
[Tracking Requested - why for this release]: 51 introduced this regression which makes main menu icons harder to see.
status-firefox51:
--- → ?
tracking-firefox51:
--- → ?
Comment 11•7 years ago
|
||
Track 51+ as 51 introduced this regression. Hi :dao, Is this worth uplifting to 51?
Assignee | ||
Comment 12•7 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: bug 1022573 only got us halfway there, this patch basically completes the fix [User impact if declined]: Icons in the main menu, identity block and control center hard to see in Windows high-contrast mode and in some cases on Linux [Describe test coverage new/current, TreeHerder]: n/a [Risks and why]: straightforward fix, low risk. This is easy to uplift now that we've already uplifted bug 1303291. [String/UUID change made/needed]: none
Attachment #8793264 -
Attachment is obsolete: true
Flags: needinfo?(dao+bmo)
Attachment #8797412 -
Flags: approval-mozilla-aurora?
Comment 13•7 years ago
|
||
Comment on attachment 8797412 [details] [diff] [review] landed patch This patch polishes UI related to icon. Take it in 51 aurora.
Attachment #8797412 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 14•7 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/581e2e9b9d79cbaf4e333447e5966e03b92a2eb7
You need to log in
before you can comment on or make changes to this bug.
Description
•