Assertion failure: [GFX1]: D3D11 device creation failed: 0x887a0004, at Logging.h:513

RESOLVED FIXED in Firefox 52

Status

()

defect
P3
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cbook, Assigned: mattwoodrow)

Tracking

(Blocks 1 bug, {assertion})

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [top-sitetestrun] [gfx-noted])

Attachments

(3 attachments)

Reporter

Description

3 years ago
Found via topsite bughunter tests on an old windows 7 workstation with FX5500 card

During startup Firefox trunk debug build crashes with:

Assertion failure: [GFX1]: D3D11 device creation failed: 0x887a0004, at c:\builds\moz2_slave\m-cen-w32-d-000000000000000000\build\src\obj-firefox\dist\include\mozilla/gfx/Logging.h:513
Reporter

Comment 2

3 years ago
Posted file stack
Reporter

Updated

3 years ago
Whiteboard: [top-sitetestrun]
David, this looks like it is related to device creation changes you made. Ideas?
Flags: needinfo?(dvander)
Priority: -- → P3
Whiteboard: [top-sitetestrun] → [top-sitetestrun] [gfx-noted]
Also, for reference: DXGI_ERROR_UNSUPPORTED = 0x887A0004
This assertion [1] was added in bug 1284672, so redirecting ni? at Matt. Probably the right answer here is to just remove the assert.

[1] http://searchfox.org/mozilla-central/rev/c31ad35f39c6187b2e121aa6d3a39b7f67397010/gfx/thebes/DeviceManagerDx.cpp#285
Flags: needinfo?(dvander) → needinfo?(matt.woodrow)
Assignee

Comment 6

3 years ago
I'm pretty sure the assertion was existing, but I agree that we should get rid of it. Failing to create a device (possibly because the system only supports d3d11 level 9.3?) shouldn't be a fatal assertion.
Flags: needinfo?(matt.woodrow)
Assignee

Comment 7

3 years ago
Assignee: nobody → matt.woodrow
Attachment #8794627 - Flags: review?(dvander)
Attachment #8794627 - Flags: review?(dvander) → review+

Comment 8

3 years ago
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6cf880cf9ec
Remove gfxCriticalError when creating a d3d11 device fails since that can happen under regular usage. r=dvander
Reporter

Comment 9

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d6cf880cf9ec
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.